abdul-traya commented on code in PR #940:
URL: https://github.com/apache/incubator-xtable/pull/940#discussion_r4012487927
##########
xtable-aws/src/main/java/org/apache/xtable/glue/table/DeltaGlueCatalogTableBuilder.java:
##########
@@ -90,13 +101,25 @@ public TableInput getUpdateTableRequest(
.tableType(GLUE_EXTERNAL_TABLE_TYPE)
.parameters(parameters)
.storageDescriptor(
- catalogTable.storageDescriptor().toBuilder()
- .columns(schemaExtractor.getNonPartitionColumns(table,
columnsMap))
- .build())
+ getStorageDescriptor(table,
schemaExtractor.getNonPartitionColumns(table, columnsMap)))
Review Comment:
Addressed in 319b545 — `getUpdateTableRequest` now builds off the existing
`StorageDescriptor` via `toBuilder()` instead of rebuilding it, so
`additionalLocations` and any custom serde parameters survive a refresh. Added
`testGetUpdateTableInputPreservesExistingStorageSettings` to cover it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
