vamsikarnika commented on code in PR #951:
URL: https://github.com/apache/incubator-xtable/pull/951#discussion_r4120072402
##########
xtable-core/src/main/java/org/apache/xtable/hudi/HudiFileStatsExtractor.java:
##########
@@ -201,8 +201,16 @@ private Optional<InternalDataFile>
tryEnrichWithMetadataStats(
fileStats.stream()
.map(pair -> getColumnStatFromHudiStat(pair.getLeft(),
pair.getRight()))
.collect(CustomCollectors.toList(fileStats.size()));
- long recordCount = getMaxFromColumnStats(columnStats).orElse(0L);
- return
Optional.of(file.toBuilder().columnStats(columnStats).recordCount(recordCount).build());
+ Optional<Long> recordCount = getMaxFromColumnStats(columnStats);
+ if (!recordCount.isPresent()) {
Review Comment:
Thanks @vinishjail97 for pointing this out. I've fixed the log now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
