vinishjail97 commented on code in PR #952:
URL: https://github.com/apache/incubator-xtable/pull/952#discussion_r4202374485
##########
xtable-utilities/pom.xml:
##########
@@ -633,10 +640,10 @@
<include>org.apache.hudi:hudi-java-client</include>
<include>org.apache.hudi:hudi-timeline-service</include>
<include>org.apache.iceberg:iceberg-api</include>
+ <include>org.apache.iceberg:iceberg-aws</include>
Review Comment:
Agreed, checking includes → tree as well would catch this whole class rather
than one instance. It touches release tooling and the License Check job scope,
so it would be good to track it separately. Filed #963.
##########
xtable-utilities/pom.xml:
##########
@@ -200,6 +200,12 @@
<groupId>org.apache.iceberg</groupId>
<artifactId>iceberg-parquet</artifactId>
</dependency>
+ <!-- GlueCatalog and S3FileIO for icebergCatalogConfig. The AWS SDK
clients it needs are
Review Comment:
Fixed in 951c05e. The comment now says that `glue` comes transitively from
`xtable-aws`, and that its include goes stale if that dependency narrows.
##########
README.md:
##########
@@ -116,6 +116,7 @@ catalogOptions: # all other options are passed through in a
map
key1: value1
key2: value2
```
+The bundled jar includes Iceberg's `org.apache.iceberg.aws.glue.GlueCatalog`
and `org.apache.iceberg.aws.s3.S3FileIO`. Other catalog implementations must be
added to the classpath, which means running with `java -cp
xtable-utilities_2.12-0.5.0-SNAPSHOT-bundled.jar:my-catalog.jar
org.apache.xtable.utilities.RunSync ...` instead of `java -jar`.
Review Comment:
Fixed in 951c05e. Moved the sentence after step 5, next to the bundled
hadoop dependencies note.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
