zhang-arvin commented on PR #931: URL: https://github.com/apache/incubator-xtable/pull/931#issuecomment-6058857224
Checked the prerequisite before retargeting: `xtable-spark-runtime` is **not** on `main` yet (it only exists on `branch-0.4`), so this PR can't be rebased onto `main` as-is — three of the five files it touches (`xtable-spark-runtime/.../TableSyncSpec.java`, `XTableSparkSync.java`, `XTableSyncService.java`) don't exist there. @vinishjail97 the two runtime PRs you linked — #838 and #839 — are still open and in draft, targeting `main`, so the spark-runtime isn't in `main` yet. So I'm leaving the base as `branch-0.4` for now: the PR is mergeable and the change itself is small (route the partition spec through `ParquetSourceConfig.PARTITION_FIELD_SPEC_CONFIG` for Parquet sources instead of the Hudi key). Plan: - Retarget to `main` (and rebase) as soon as the spark-runtime lands in `main` — whichever path #838/#839 ends up taking. Ping me when one merges and I'll re-point it immediately. - In the meantime I'm happy to help on the runtime work: I can review #838/#839, or if you'd rather hand off part of it (e.g. the Hudi 1.2.1 bump), say the word and I'll pick it up so we can unblock the `main` target sooner. @the-other-tim-brown the 0.4.x cherry-pick path is orthogonal and fine by me — this change is small enough to cherry-pick cleanly once it's on `main`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
