vinishjail97 commented on code in PR #824: URL: https://github.com/apache/incubator-xtable/pull/824#discussion_r4223448887
########## xtable-core/src/main/java/org/apache/xtable/hudi/HudiDataFileExtractor.java: ########## Review Comment: Thanks @vaibhavk1992, good catch to look at the replace path too. I checked it, and I think incremental sync cannot reach a cleaned replaced file group here. CLEAN only deletes replaced groups whose replace instant is older than `earliestCommitToRetain`, and `ConversionController.isIncrementalSyncSufficient` checks from the earliest of the last synced instant and the pending instants, so that sync falls back to snapshot. I added `testSyncFallsBackToSnapshotWhenCleanDeletesReplacedFileGroupsOfPendingCommit` in 620039e6 to pin this. It covers async clustering that completes after a sync and is cleaned before the next one. Please correct me if you had a different sequence in mind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
