Mola-maker commented on PR #973: URL: https://github.com/apache/incubator-xtable/pull/973#issuecomment-6412382518
Thanks for verifying end to end and for the precise repro — all three points addressed in the latest push (commit cf7a2043): 1. Null partition value: fixed exactly as suggested, in both DeltaPartitionExtractor and DeltaKernelPartitionExtractor — once the map contains the storage key, its value (including null) is authoritative and no longer falls back to the logical name. Regression tests added to TestDeltaPartitionExtractor and TestDeltaKernelPartitionExtractor mirroring the rename collision (a null under the storage key must not resolve to the logical name's entry). 2. Kernel-path IT: added testLateColumnMappingRenameDeltaToIceberg, run against both the Kernel and the Standalone Delta sources. It enables column mapping after data exists, applies the double rename (level -> tmp, street -> level), inserts a row with tmp=X and a null level partition value, syncs to Iceberg, and asserts the Iceberg row reads back tmp=X, level=NULL (plus full dataset equivalence). Running both sources also covers #886. 3. Generated partition columns: left as a separate follow-up as you suggested, not in this PR. One environment note: I can't run the JVM tests locally in this environment, so the new unit tests and ITs rely on CI here — the fork CI run for this push will tell us. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
