the-other-tim-brown commented on code in PR #984:
URL: https://github.com/apache/incubator-xtable/pull/984#discussion_r4382291588
##########
xtable-core/src/main/java/org/apache/xtable/kernel/DeltaKernelSchemaExtractor.java:
##########
@@ -381,10 +380,9 @@ private DataType convertFieldType(InternalField field) {
private FieldMetadata getFieldMetadata(InternalField field) {
FieldMetadata.Builder metadataBuilder = FieldMetadata.builder();
- // Propagate column mapping ID to maintain Delta column mapping
- if (field.getFieldId() != null) {
- metadataBuilder.putLong(DELTA_COLUMN_MAPPING_ID,
field.getFieldId().longValue());
- }
+ // Column-mapping IDs are only valid when the target enables Delta column
mapping. This
Review Comment:
Wouldn't it be better to enable the feature in the case where the field IDs
are set?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
