slachiewicz opened a new pull request, #990: URL: https://github.com/apache/incubator-xtable/pull/990
Part of #865. Split out of #895, which carries the same discovery change. ## What is the purpose of the pull request `validate_shaded_license_coverage.sh` finds the shaded modules with `rg`, which `ubuntu-latest` does not have. On every run since June it logged `rg: command not found`, found no modules and exited 0, so the License Check has not checked shade includes against the runtime dependency tree or the bundled license metadata. This lands the discovery fix on its own, so the check works before 0.5.0 whichever way the license model in #895 and #898 goes. With discovery working, the check fails on `xtable-hive-metastore`: 36 shaded artifacts are not in its runtime tree, and `hive-standalone-metastore` and `calcite-core` are in the tree but not shaded. `xtable-aws`, `xtable-hudi-support-extensions` and `xtable-spark-runtime` pass. #895 regenerates those includes, so this PR stays a draft until it can land with or after that change. ## Brief change log - Find the shaded modules with `git grep` instead of `rg`. - Fail when no module is found, instead of passing. ## Verify this pull request Verified: `release/scripts/validate_shaded_license_coverage.sh` on this branch → `xtable-hive-metastore` FAIL (the diff above), the other three modules OK, exit 1; the same result `main`'s script gives on a machine that has `rg`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
