HADOOP-12315. hbaseprotoc_postapply in the test-patch hbase personality can return a wrong status (Kengo Seki via aw)
Project: http://git-wip-us.apache.org/repos/asf/yetus/repo Commit: http://git-wip-us.apache.org/repos/asf/yetus/commit/d32053a6 Tree: http://git-wip-us.apache.org/repos/asf/yetus/tree/d32053a6 Diff: http://git-wip-us.apache.org/repos/asf/yetus/diff/d32053a6 Branch: refs/heads/master Commit: d32053a67272cc1c1873ba614ca9df1828ab32c4 Parents: 495f95e Author: Allen Wittenauer <[email protected]> Authored: Thu Aug 13 12:51:00 2015 -0700 Committer: Allen Wittenauer <[email protected]> Committed: Thu Aug 13 12:51:00 2015 -0700 ---------------------------------------------------------------------- dev-support/personality/hbase.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/yetus/blob/d32053a6/dev-support/personality/hbase.sh ---------------------------------------------------------------------- diff --git a/dev-support/personality/hbase.sh b/dev-support/personality/hbase.sh index d8ca901..9749096 100755 --- a/dev-support/personality/hbase.sh +++ b/dev-support/personality/hbase.sh @@ -146,7 +146,7 @@ function hbaseprotoc_postapply local module local logfile local count - local results + local result big_console_header "Patch HBase protoc plugin" @@ -159,7 +159,7 @@ function hbaseprotoc_postapply fi personality_modules patch hbaseprotoc - modules_workers patch hbaseprotoc -DskipTests -Pcompile-protobuf -X -DHBasePatchProcess + modules_workers patch hbaseprotoc compile -DskipTests -Pcompile-protobuf -X -DHBasePatchProcess # shellcheck disable=SC2153 until [[ $i -eq ${#MODULE[@]} ]]; do @@ -177,13 +177,13 @@ function hbaseprotoc_postapply if [[ ${count} -gt 0 ]]; then module_status ${i} -1 "patch-hbaseprotoc-${fn}.txt" "Patch generated "\ "${count} new protoc errors in ${module}." - ((results=results+1)) + ((result=result+1)) fi ((i=i+1)) done modules_messages patch hbaseprotoc true - if [[ ${results} -gt 0 ]]; then + if [[ ${result} -gt 0 ]]; then return 1 fi return 0
