This is an automated email from the ASF dual-hosted git repository.
aw pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/yetus.git
The following commit(s) were added to refs/heads/master by this push:
new 5d55cd5 YETUS-721. personalities shouldn't directly set repository
information
5d55cd5 is described below
commit 5d55cd5372ddeaf4498b5e8755b5f407e8e33964
Author: Allen Wittenauer <[email protected]>
AuthorDate: Sun Dec 30 23:39:16 2018 -0800
YETUS-721. personalities shouldn't directly set repository information
Signed-off-by: Allen Wittenauer <[email protected]>
---
precommit/src/main/shell/personality/accumulo.sh | 2 +-
precommit/src/main/shell/personality/bigtop.sh | 2 +-
precommit/src/main/shell/personality/drill.sh | 2 +-
precommit/src/main/shell/personality/flink.sh | 2 +-
precommit/src/main/shell/personality/geode.sh | 2 +-
precommit/src/main/shell/personality/hadoop.sh | 2 +-
precommit/src/main/shell/personality/hbase.sh | 2 +-
precommit/src/main/shell/personality/jmeter.sh | 2 +-
precommit/src/main/shell/personality/kafka.sh | 2 +-
precommit/src/main/shell/personality/orc.sh | 2 +-
precommit/src/main/shell/personality/pig.sh | 2 +-
precommit/src/main/shell/personality/ratis.sh | 2 +-
precommit/src/main/shell/personality/samza.sh | 2 +-
precommit/src/main/shell/personality/tajo.sh | 2 +-
precommit/src/main/shell/personality/tez.sh | 2 +-
precommit/src/main/shell/personality/yetus.sh | 2 +-
precommit/src/main/shell/test-patch.d/github.sh | 7 +++++++
precommit/src/main/shell/test-patch.d/gitlab.sh | 4 ++++
18 files changed, 27 insertions(+), 16 deletions(-)
diff --git a/precommit/src/main/shell/personality/accumulo.sh
b/precommit/src/main/shell/personality/accumulo.sh
index f2d3e7c..479ead4 100755
--- a/precommit/src/main/shell/personality/accumulo.sh
+++ b/precommit/src/main/shell/personality/accumulo.sh
@@ -29,7 +29,7 @@ function personality_globals
#shellcheck disable=SC2034
JIRA_ISSUE_RE='^ACCUMULO-[0-9]+$'
#shellcheck disable=SC2034
- GITHUB_REPO="apache/accumulo"
+ GITHUB_REPO_DEFAULT="apache/accumulo"
#shellcheck disable=SC2034
PATCH_NAMING_RULE="http://accumulo.apache.org/git.html#contributors";
# We want to invoke the 'check' goal, not the default 'checkstyle'. We define
diff --git a/precommit/src/main/shell/personality/bigtop.sh
b/precommit/src/main/shell/personality/bigtop.sh
index c374289..6e84416 100755
--- a/precommit/src/main/shell/personality/bigtop.sh
+++ b/precommit/src/main/shell/personality/bigtop.sh
@@ -28,5 +28,5 @@ function personality_globals
# shellcheck disable=SC2034
BUILDTOOL=gradle
# shellcheck disable=SC2034
- GITHUB_REPO="apache/bigtop"
+ GITHUB_REPO_DEFAULT="apache/bigtop"
}
diff --git a/precommit/src/main/shell/personality/drill.sh
b/precommit/src/main/shell/personality/drill.sh
index cc35d45..4686cb6 100755
--- a/precommit/src/main/shell/personality/drill.sh
+++ b/precommit/src/main/shell/personality/drill.sh
@@ -24,7 +24,7 @@ function personality_globals
# shellcheck disable=SC2034
BUILDTOOL=maven
#shellcheck disable=SC2034
- GITHUB_REPO="apache/drill"
+ GITHUB_REPO_DEFAULT="apache/drill"
#shellcheck disable=SC2034
PATCH_NAMING_RULE="https://drill.apache.org/docs/apache-drill-contribution-guidelines/";
#shellcheck disable=SC2034
diff --git a/precommit/src/main/shell/personality/flink.sh
b/precommit/src/main/shell/personality/flink.sh
index 971783a..7694226 100755
--- a/precommit/src/main/shell/personality/flink.sh
+++ b/precommit/src/main/shell/personality/flink.sh
@@ -28,7 +28,7 @@ function personality_globals
#shellcheck disable=SC2034
JIRA_ISSUE_RE='^FLINK-[0-9]+$'
#shellcheck disable=SC2034
- GITHUB_REPO="apache/flink"
+ GITHUB_REPO_DEFAULT="apache/flink"
}
add_test_type flinklib
diff --git a/precommit/src/main/shell/personality/geode.sh
b/precommit/src/main/shell/personality/geode.sh
index 9f5c0ec..75162cc 100755
--- a/precommit/src/main/shell/personality/geode.sh
+++ b/precommit/src/main/shell/personality/geode.sh
@@ -28,7 +28,7 @@ function personality_globals
#shellcheck disable=SC2034
JIRA_ISSUE_RE='^(GEODE)-[0-9]+$'
#shellcheck disable=SC2034
- GITHUB_REPO="apache/incubator-geode"
+ GITHUB_REPO_DEFAULT="apache/incubator-geode"
#shellcheck disable=SC2034
BUILDTOOL=gradle
# PYLINT_OPTIONS="--indent-string=' '"
diff --git a/precommit/src/main/shell/personality/hadoop.sh
b/precommit/src/main/shell/personality/hadoop.sh
index 5323cc0..8cbf8cc 100755
--- a/precommit/src/main/shell/personality/hadoop.sh
+++ b/precommit/src/main/shell/personality/hadoop.sh
@@ -35,7 +35,7 @@ function personality_globals
#shellcheck disable=SC2034
JIRA_ISSUE_RE='^(HADOOP|YARN|MAPREDUCE|HDFS|HDDS)-[0-9]+$'
#shellcheck disable=SC2034
- GITHUB_REPO="apache/hadoop"
+ GITHUB_REPO_DEFAULT="apache/hadoop"
#shellcheck disable=SC2034
PYLINT_OPTIONS="--indent-string=' '"
diff --git a/precommit/src/main/shell/personality/hbase.sh
b/precommit/src/main/shell/personality/hbase.sh
index 5de4305..d9e809f 100755
--- a/precommit/src/main/shell/personality/hbase.sh
+++ b/precommit/src/main/shell/personality/hbase.sh
@@ -29,7 +29,7 @@ function personality_globals
#shellcheck disable=SC2034
JIRA_ISSUE_RE='^HBASE-[0-9]+$'
#shellcheck disable=SC2034
- GITHUB_REPO="apache/hbase"
+ GITHUB_REPO_DEFAULT="apache/hbase"
# TODO use PATCH_BRANCH to select hadoop versions to use.
# All supported Hadoop versions that we want to test the compilation with
diff --git a/precommit/src/main/shell/personality/jmeter.sh
b/precommit/src/main/shell/personality/jmeter.sh
index cb2cb1a..f2a6056 100755
--- a/precommit/src/main/shell/personality/jmeter.sh
+++ b/precommit/src/main/shell/personality/jmeter.sh
@@ -26,7 +26,7 @@ function personality_globals
# shellcheck disable=SC2034
BUILDTOOL=ant
# shellcheck disable=SC2034
- GITHUB_REPO="apache/jmeter"
+ GITHUB_REPO_DEFAULT="apache/jmeter"
# shellcheck disable=SC2034
JMETER_DOWNLOAD_JARS=false
}
diff --git a/precommit/src/main/shell/personality/kafka.sh
b/precommit/src/main/shell/personality/kafka.sh
index ceb2604..a81ee1c 100755
--- a/precommit/src/main/shell/personality/kafka.sh
+++ b/precommit/src/main/shell/personality/kafka.sh
@@ -30,7 +30,7 @@ function personality_globals
# shellcheck disable=SC2034
BUILDTOOL=gradle
#shellcheck disable=SC2034
- GITHUB_REPO="apache/kafka"
+ GITHUB_REPO_DEFAULT="apache/kafka"
}
## @description Queue up modules for this personality
diff --git a/precommit/src/main/shell/personality/orc.sh
b/precommit/src/main/shell/personality/orc.sh
index 0582b17..95868ba 100755
--- a/precommit/src/main/shell/personality/orc.sh
+++ b/precommit/src/main/shell/personality/orc.sh
@@ -28,7 +28,7 @@ function personality_globals
# shellcheck disable=SC2034
BUILDTOOL=cmake
#shellcheck disable=SC2034
- GITHUB_REPO="apache/orc"
+ GITHUB_REPO_DEFAULT="apache/orc"
# protobuf fails
#shellcheck disable=SC2034
diff --git a/precommit/src/main/shell/personality/pig.sh
b/precommit/src/main/shell/personality/pig.sh
index 2014fda..0c88557 100755
--- a/precommit/src/main/shell/personality/pig.sh
+++ b/precommit/src/main/shell/personality/pig.sh
@@ -26,7 +26,7 @@ function personality_globals
#shellcheck disable=SC2034
JIRA_ISSUE_RE='^PIG-[0-9]+$'
#shellcheck disable=SC2034
- GITHUB_REPO="apache/pig"
+ GITHUB_REPO_DEFAULT="apache/pig"
#shellcheck disable=SC2034
BUILDTOOL=ant
}
diff --git a/precommit/src/main/shell/personality/ratis.sh
b/precommit/src/main/shell/personality/ratis.sh
index d700512..d3f0ae2 100755
--- a/precommit/src/main/shell/personality/ratis.sh
+++ b/precommit/src/main/shell/personality/ratis.sh
@@ -28,5 +28,5 @@ function personality_globals
#shellcheck disable=SC2034
JIRA_ISSUE_RE='^RATIS-[0-9]+$'
#shellcheck disable=SC2034
- GITHUB_REPO="apache/incubator-ratis"
+ GITHUB_REPO_DEFAULT="apache/incubator-ratis"
}
diff --git a/precommit/src/main/shell/personality/samza.sh
b/precommit/src/main/shell/personality/samza.sh
index 430ffbb..4e84702 100755
--- a/precommit/src/main/shell/personality/samza.sh
+++ b/precommit/src/main/shell/personality/samza.sh
@@ -30,5 +30,5 @@ function personality_globals
# shellcheck disable=SC2034
BUILDTOOL=gradle
#shellcheck disable=SC2034
- GITHUB_REPO="apache/samza"
+ GITHUB_REPO_DEFAULT="apache/samza"
}
diff --git a/precommit/src/main/shell/personality/tajo.sh
b/precommit/src/main/shell/personality/tajo.sh
index fb86ff7..90a575f 100755
--- a/precommit/src/main/shell/personality/tajo.sh
+++ b/precommit/src/main/shell/personality/tajo.sh
@@ -28,7 +28,7 @@ function personality_globals
#shellcheck disable=SC2034
JIRA_ISSUE_RE='^TAJO-[0-9]+$'
#shellcheck disable=SC2034
- GITHUB_REPO="apache/tajo"
+ GITHUB_REPO_DEFAULT="apache/tajo"
#shellcheck disable=SC2034
PATCH_NAMING_RULE="https://cwiki.apache.org/confluence/display/TAJO/How+to+Contribute+to+Tajo";
}
diff --git a/precommit/src/main/shell/personality/tez.sh
b/precommit/src/main/shell/personality/tez.sh
index 32d9ffc..36bc426 100755
--- a/precommit/src/main/shell/personality/tez.sh
+++ b/precommit/src/main/shell/personality/tez.sh
@@ -28,7 +28,7 @@ function personality_globals
#shellcheck disable=SC2034
JIRA_ISSUE_RE='^TEZ-[0-9]+$'
#shellcheck disable=SC2034
- GITHUB_REPO="apache/tez"
+ GITHUB_REPO_DEFAULT="apache/tez"
#shellcheck disable=SC2034
PATCH_NAMING_RULE="https://cwiki.apache.org/confluence/display/TEZ/How+to+Contribute+to+Tez";
}
diff --git a/precommit/src/main/shell/personality/yetus.sh
b/precommit/src/main/shell/personality/yetus.sh
index 527aa9c..24c1815 100755
--- a/precommit/src/main/shell/personality/yetus.sh
+++ b/precommit/src/main/shell/personality/yetus.sh
@@ -28,7 +28,7 @@ function personality_globals
#shellcheck disable=SC2034
JIRA_ISSUE_RE='^YETUS-[0-9]+$'
#shellcheck disable=SC2034
- GITHUB_REPO="apache/yetus"
+ GITHUB_REPO_DEFAULT="apache/yetus"
}
## @description Queue up modules for this personality
diff --git a/precommit/src/main/shell/test-patch.d/github.sh
b/precommit/src/main/shell/test-patch.d/github.sh
index be1893d..713fa7a 100755
--- a/precommit/src/main/shell/test-patch.d/github.sh
+++ b/precommit/src/main/shell/test-patch.d/github.sh
@@ -151,6 +151,13 @@ function github_breakup_url
fi
}
+## @description initalize github
+function github_initialize
+{
+ if [[ -z "${GITHUB_REPO}" ]]; then
+ GITHUB_REPO=${GITHUB_REPO_DEFAULT:-}
+ fi
+}
## @description based upon a github PR, attempt to link back to JIRA
function github_find_jira_title
diff --git a/precommit/src/main/shell/test-patch.d/gitlab.sh
b/precommit/src/main/shell/test-patch.d/gitlab.sh
index a86754d..6e86792 100755
--- a/precommit/src/main/shell/test-patch.d/gitlab.sh
+++ b/precommit/src/main/shell/test-patch.d/gitlab.sh
@@ -72,6 +72,10 @@ function gitlab_parse_args
function gitlab_initialize
{
+ if [[ -z "${GITLAB_REPO}" ]]; then
+ GITLAB_REPO=${GITLAB_REPO_DEFAULT:-}
+ fi
+
# convert the repo into a URL encoded one. Need this for lots of things.
GITLAB_REPO_ENC=${GITLAB_REPO/\//%2F}
}
