Repository: zeppelin Updated Branches: refs/heads/master 6a82e7aab -> 60186d8bb
[ZEPPELIN-1122] BugFix for repositories snapshot is always set to true. ### What is this PR for? This PR fixes a bug about snapshot setting and select box(true,false) html. ### What type of PR is it? Bug Fix | Improvement ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1122 ### How should this be tested? 1. go Interpreter menu. 2. click ```repository information``` button that is right top. 3. click plus button (to Add New Repository) and refer to screenshot. ### Screenshots (if appropriate) - before  - after  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: astroshim <[email protected]> Closes #1137 from astroshim/ZEPPELIN-1122 and squashes the following commits: 0ce28a0 [astroshim] rebase be684c8 [astroshim] remove snapshot from popup 829e9c1 [astroshim] fix select box and snapshot backend code. Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/60186d8b Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/60186d8b Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/60186d8b Branch: refs/heads/master Commit: 60186d8bb9c3b4ccfc63f1326400618fd59a5d02 Parents: 6a82e7a Author: astroshim <[email protected]> Authored: Sun Jul 10 20:51:29 2016 +0900 Committer: Alexander Bezzubov <[email protected]> Committed: Mon Jul 11 11:04:21 2016 +0900 ---------------------------------------------------------------------- zeppelin-web/src/app/interpreter/interpreter.html | 11 ++++------- .../components/repository-create/repository-dialog.html | 7 ++++--- 2 files changed, 8 insertions(+), 10 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/zeppelin/blob/60186d8b/zeppelin-web/src/app/interpreter/interpreter.html ---------------------------------------------------------------------- diff --git a/zeppelin-web/src/app/interpreter/interpreter.html b/zeppelin-web/src/app/interpreter/interpreter.html index af3b844..d96fadf 100644 --- a/zeppelin-web/src/app/interpreter/interpreter.html +++ b/zeppelin-web/src/app/interpreter/interpreter.html @@ -58,17 +58,14 @@ limitations under the License. <a tabindex="0" class="btn btn-info" role="button" popover-trigger="focus" popover-placement="right" - popover-html-unsafe=" - <label>URL: </label> - {{repo.url}}<br/> - <label>Snapshot: </label> - {{repo.snapshotPolicy.enabled}}<br/> + popover-html-unsafe="<label>URL: </label> + {{repo.url}}<br> <label>Username: </label> {{repo.authentication.username}}"> <span class="fa fa-database"></span> {{repo.id}} - <span ng-if="!isDefaultRepository(repo.id)" - class="fa fa-close blackOpc" ng-click="removeRepository(repo.id)"></span> + <span ng-if="!isDefaultRepository(repo.id)" class="fa fa-close blackOpc" + ng-click="removeRepository(repo.id)"></span> </a> </li> <li class="liVertical"> http://git-wip-us.apache.org/repos/asf/zeppelin/blob/60186d8b/zeppelin-web/src/components/repository-create/repository-dialog.html ---------------------------------------------------------------------- diff --git a/zeppelin-web/src/components/repository-create/repository-dialog.html b/zeppelin-web/src/components/repository-create/repository-dialog.html index 1bc7b07..d2efec3 100644 --- a/zeppelin-web/src/components/repository-create/repository-dialog.html +++ b/zeppelin-web/src/components/repository-create/repository-dialog.html @@ -43,9 +43,10 @@ limitations under the License. <div class="form-group"> <label class="control-label col-sm-2" for="repoSnapshot">Snapshot</label> <div class="col-sm-10"> - <select class="form-control" id="repoSnapshot" ng-model="newRepoSetting.snapshot"> - <option ng-selected="true">false</option> - <option>true</option> + <select class="form-control" + id="repoSnapshot" + ng-model="newRepoSetting.snapshot" + ng-options="col for col in [false,true]"> </select> </div> </div>
