Repository: zeppelin
Updated Branches:
refs/heads/branch-0.6 e5b36102a -> 6ad31609f
[HOTFIX] build fail after merge #1151
### What is this PR for?
#1151 has been created created before #1139 merge.
#1151 was passing CI but it's failing in master with #1139 merged.
```
[INFO] --- frontend-maven-plugin:0.0.25:grunt (grunt build) zeppelin-web ---
[INFO] Running 'grunt build --no-color' in
/Users/moon/Projects/zeppelin/zeppelin-web
[INFO] Running "jscs:all" (jscs) task
[INFO] requireSpaceBeforeBinaryOperators: Operator = should not stick to
preceding expression at src/components/saveAs/saveAs.service.js :
[INFO] 21 | angular.element('body').append('<iframe id="SaveAsId"
style="display: none"></iframe>');
[INFO] 22 | var frameSaveAs = angular.element('body >
iframe#SaveAsId')[0].contentWindow;
[INFO] 23 | content= BOM + content;
[INFO] ---------------------^
[INFO] 24 | frameSaveAs.document.open('text/json', 'replace');
[INFO] 25 | frameSaveAs.document.write(content);
[INFO] >> 1 code style errors found!
[INFO] Warning: Task "jscs:all" failed. Use --force to continue.
[INFO]
[INFO] Aborted due to warnings.
```
### What type of PR is it?
Hot Fix
### Todos
* [x] - Fix problem
### What is the Jira issue?
ZEPPELIN-1138, ZEPPELIN-235
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
Author: Lee moon soo <[email protected]>
Closes #1165 from Leemoonsoo/fix_js and squashes the following commits:
3819ffb [Lee moon soo] add space
(cherry picked from commit 0590ef3d9bf77c68126c5e6db3953ab2d9f5dcad)
Signed-off-by: Lee moon soo <[email protected]>
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/6ad31609
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/6ad31609
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/6ad31609
Branch: refs/heads/branch-0.6
Commit: 6ad31609f547de68f7c18c2d94a8e73e63972d98
Parents: e5b3610
Author: Lee moon soo <[email protected]>
Authored: Mon Jul 11 10:24:29 2016 -0700
Committer: Lee moon soo <[email protected]>
Committed: Mon Jul 11 10:38:19 2016 -0700
----------------------------------------------------------------------
zeppelin-web/src/components/saveAs/saveAs.service.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/6ad31609/zeppelin-web/src/components/saveAs/saveAs.service.js
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/components/saveAs/saveAs.service.js
b/zeppelin-web/src/components/saveAs/saveAs.service.js
index 99a685c..8164edb 100644
--- a/zeppelin-web/src/components/saveAs/saveAs.service.js
+++ b/zeppelin-web/src/components/saveAs/saveAs.service.js
@@ -20,7 +20,7 @@ angular.module('zeppelinWebApp').service('SaveAsService',
function(browserDetect
if (browserDetectService.detectIE()) {
angular.element('body').append('<iframe id="SaveAsId" style="display:
none"></iframe>');
var frameSaveAs = angular.element('body >
iframe#SaveAsId')[0].contentWindow;
- content= BOM + content;
+ content = BOM + content;
frameSaveAs.document.open('text/json', 'replace');
frameSaveAs.document.write(content);
frameSaveAs.document.close();