Repository: zeppelin Updated Branches: refs/heads/master b1e6e2c20 -> 94fa6a50d
[ZEPPELIN-1091] Disable ace editor's showSettingsMenu in paragraph. ### What is this PR for? This PR prevent to show the ace editor's showSettingMenu screen. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1091 ### How should this be tested? Type "Ctrl+." on your paragraph. ### Screenshots (if appropriate) - before  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: astroshim <[email protected]> Closes #1110 from astroshim/ZEPPELIN-1091 and squashes the following commits: 9ff2886 [astroshim] rebase c736db0 [astroshim] disable showSettingsMenu Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/94fa6a50 Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/94fa6a50 Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/94fa6a50 Branch: refs/heads/master Commit: 94fa6a50d71dddc3365a142c5b532abfeb100731 Parents: b1e6e2c Author: astroshim <[email protected]> Authored: Tue Jul 12 19:21:39 2016 +0900 Committer: Damien CORNEAU <[email protected]> Committed: Thu Jul 14 12:28:31 2016 +0900 ---------------------------------------------------------------------- zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js | 1 + 1 file changed, 1 insertion(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/zeppelin/blob/94fa6a50/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js ---------------------------------------------------------------------- diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js b/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js index da4004f..a968e08 100644 --- a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js +++ b/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js @@ -903,6 +903,7 @@ angular.module('zeppelinWebApp').controller('ParagraphCtrl', function($scope, $r // remove binding $scope.editor.commands.bindKey('ctrl-alt-n.', null); + $scope.editor.commands.removeCommand('showSettingsMenu'); // autocomplete on 'ctrl+.' $scope.editor.commands.bindKey('ctrl-.', 'startAutocomplete');
