Repository: zeppelin Updated Branches: refs/heads/master 04da56403 -> a2a229d16
[MINOR] Fix missing validation on interpreter page ### What is this PR for? Fix missing validation on interpreter page. TypeError on console when Save interpreter settings button is clicked without specifying any value. ### What type of PR is it? Bug Fix ### Todos * [ ] - Task ### What is the Jira issue? n/a ### How should this be tested? 1) go to interpreter settings page and click on create buttons 2) click on save without filling any fields ### Screenshots (if appropriate) before fix <img width="666" alt="screen shot 2016-07-29 at 5 26 28 pm" src="https://cloud.githubusercontent.com/assets/2031306/17248223/c3b7a194-55b6-11e6-9746-5d912a723f6a.png";> ### Questions: * Does the licenses files need update? n/a * Is there breaking changes for older versions? n/a * Does this needs documentation? n/a Author: Renjith Kamath <[email protected]> Closes #1246 from r-kamath/interpreterPageFix and squashes the following commits: 0ccf515 [Renjith Kamath] Fix missing validation on interpreter page Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/a2a229d1 Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/a2a229d1 Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/a2a229d1 Branch: refs/heads/master Commit: a2a229d160c51991177d2a606d8116267a1a7f8a Parents: 04da564 Author: Renjith Kamath <[email protected]> Authored: Fri Jul 29 18:00:55 2016 +0530 Committer: Prabhjyot Singh <[email protected]> Committed: Mon Aug 1 11:40:21 2016 +0530 ---------------------------------------------------------------------- zeppelin-web/src/app/interpreter/interpreter.controller.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/zeppelin/blob/a2a229d1/zeppelin-web/src/app/interpreter/interpreter.controller.js ---------------------------------------------------------------------- diff --git a/zeppelin-web/src/app/interpreter/interpreter.controller.js b/zeppelin-web/src/app/interpreter/interpreter.controller.js index e152d57..d1e8889 100644 --- a/zeppelin-web/src/app/interpreter/interpreter.controller.js +++ b/zeppelin-web/src/app/interpreter/interpreter.controller.js @@ -249,7 +249,8 @@ angular.module('zeppelinWebApp').controller('InterpreterCtrl', $scope.addNewInterpreterSetting = function() { //user input validation on interpreter creation - if (!$scope.newInterpreterSetting.name.trim() || !$scope.newInterpreterSetting.group) { + if ($scope.newInterpreterSetting.name && + !$scope.newInterpreterSetting.name.trim() || !$scope.newInterpreterSetting.group) { BootstrapDialog.alert({ closable: true, title: 'Add interpreter',
![https://cloud.githubusercontent.com/assets/2031306/17248223/c3b7a194-55b6-11e6-9746-5d912a723f6a.png"](https://cloud.githubusercontent.com/assets/2031306/17248223/c3b7a194-55b6-11e6-9746-5d912a723f6a.png"){kind=link}