Repository: zeppelin
Updated Branches:
  refs/heads/branch-0.6 72581f35e -> 115fb24fe


[BugFix] Show checkbox for "Connect to existing process" on interpreter menu.

This PR fixes a bug of showing checkbox for "Connect to existing process" on 
interpreter menu.

Bug Fix

Go to interpreter menu and check if checkbox for "Connect to existing process" 
exists.

- before
![image](https://cloud.githubusercontent.com/assets/3348133/17141824/aa316672-5388-11e6-952d-50a3769a01a5.png)

- after
![image](https://cloud.githubusercontent.com/assets/3348133/17141840/babfad8c-5388-11e6-9209-e37e252e95b4.png)

* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: astroshim <[email protected]>

Closes #1229 from astroshim/bugfix/showCheckbox and squashes the following 
commits:

4b3673a [astroshim] add css to interpreter-create page
17fb0d7 [astroshim] change size to px
47ce719 [astroshim] remove height style on the checkbox
bbc3283 [astroshim] show checkbox on interpreter menu.

(cherry picked from commit 55695c9c31d4b2b9978cd27a19a64c95f682d637)
Signed-off-by: Damien CORNEAU <[email protected]>


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/115fb24f
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/115fb24f
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/115fb24f

Branch: refs/heads/branch-0.6
Commit: 115fb24fe3794f5e45ef32656e2b1fe45b54a367
Parents: 72581f3
Author: astroshim <[email protected]>
Authored: Sat Aug 6 22:10:51 2016 +0900
Committer: Damien CORNEAU <[email protected]>
Committed: Sun Aug 7 11:33:24 2016 +0900

----------------------------------------------------------------------
 .../app/interpreter/interpreter-create/interpreter-create.html | 6 +++---
 zeppelin-web/src/app/interpreter/interpreter.html              | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/115fb24f/zeppelin-web/src/app/interpreter/interpreter-create/interpreter-create.html
----------------------------------------------------------------------
diff --git 
a/zeppelin-web/src/app/interpreter/interpreter-create/interpreter-create.html 
b/zeppelin-web/src/app/interpreter/interpreter-create/interpreter-create.html
index d802b53..4985483 100644
--- 
a/zeppelin-web/src/app/interpreter/interpreter-create/interpreter-create.html
+++ 
b/zeppelin-web/src/app/interpreter/interpreter-create/interpreter-create.html
@@ -69,11 +69,11 @@ limitations under the License.
           <span>Interpreter for note</span>
         </div>
         <br />
-        
+
         <div class="col-md-12" style="padding-left:0px">
           <div class="checkbox">
-            <span class="input-group">
-              <label><input type="checkbox" style="width:0%;height:0%" 
ng-model="newInterpreterSetting.option.isExistingProcess"> </input> Connect to 
existing process </label>
+            <span class="input-group" style="line-height:30px;">
+              <label><input type="checkbox" style="width:20px" 
ng-model="newInterpreterSetting.option.isExistingProcess"/> Connect to existing 
process </label>
             </span>
           </div>
         </div>

http://git-wip-us.apache.org/repos/asf/zeppelin/blob/115fb24f/zeppelin-web/src/app/interpreter/interpreter.html
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/interpreter/interpreter.html 
b/zeppelin-web/src/app/interpreter/interpreter.html
index 643dd6f..d497668 100644
--- a/zeppelin-web/src/app/interpreter/interpreter.html
+++ b/zeppelin-web/src/app/interpreter/interpreter.html
@@ -153,9 +153,9 @@ limitations under the License.
       <br />
       <div class="col-md-12">
         <div class="checkbox">
-          <span class="input-group">
-            <label><input type="checkbox" style="width:0%;height:0%" 
id="isExistingProcess" ng-model="setting.option.isExistingProcess" 
ng-disabled="!valueform.$visible"> </input>
-            Connect to existing process <label>
+          <span class="input-group" style="line-height:30px;">
+            <label><input type="checkbox" style="width:20px" 
id="isExistingProcess" ng-model="setting.option.isExistingProcess" 
ng-disabled="!valueform.$visible"/>
+            Connect to existing process </label>
           </span>
         </div>
       </div>

Reply via email to