Repository: zeppelin Updated Branches: refs/heads/master 68c43e240 -> 3bd94ddc7
[ZEPPELIN-1312] Hotfix - consistent getNoteRevision in websocket call ### What is this PR for? This pr fixes inconsistency on websocket call of getNoteRevision method on frontend, since backend waits for `Revision` but front sends `RevisionId`. This is the simplest fix without api change. ### What type of PR is it? Hot Fix ### Todos * [x] - `RevisionId` -> `Revision` ### What is the Jira issue? [Zeppelin-1312](https://issues.apache.org/jira/browse/ZEPPELIN-1312) ### How should this be tested? CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Khalid Huseynov <[email protected]> Closes #1308 from khalidhuseynov/hotfix/zeppelin-1312 and squashes the following commits: d6b39ce [Khalid Huseynov] make front consistent with backend: revisionId -> revision Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/3bd94ddc Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/3bd94ddc Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/3bd94ddc Branch: refs/heads/master Commit: 3bd94ddc77ef9f9853ae978bf024d206378f16ba Parents: 68c43e2 Author: Khalid Huseynov <[email protected]> Authored: Tue Aug 9 12:06:09 2016 +0400 Committer: Alexander Bezzubov <[email protected]> Committed: Tue Aug 9 18:39:02 2016 +0900 ---------------------------------------------------------------------- .../src/components/websocketEvents/websocketMsg.service.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/zeppelin/blob/3bd94ddc/zeppelin-web/src/components/websocketEvents/websocketMsg.service.js ---------------------------------------------------------------------- diff --git a/zeppelin-web/src/components/websocketEvents/websocketMsg.service.js b/zeppelin-web/src/components/websocketEvents/websocketMsg.service.js index 0e4034c..f2af89e 100644 --- a/zeppelin-web/src/components/websocketEvents/websocketMsg.service.js +++ b/zeppelin-web/src/components/websocketEvents/websocketMsg.service.js @@ -170,12 +170,12 @@ angular.module('zeppelinWebApp').service('websocketMsgSrv', function($rootScope, }); }, - getNoteRevision: function(noteId, revisionId) { + getNoteRevision: function(noteId, revision) { websocketEvents.sendNewEvent({ op: 'NOTE_REVISION', data: { noteId: noteId, - revisionId: revisionId + revision: revision } }); },
