Repository: zeppelin Updated Branches: refs/heads/master a648746b5 -> 14479fd7a
[ZEPPELIN-1804] Added Link this paragraph to keyboard shortcut ### What is this PR for? Each paragraph menu, it has "Link this paragraph" function which is link each of the paragraph but there is not shortcut key. ### What type of PR is it? [ Improvement ] ### Todos * None ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1804 ### How should this be tested? Please press Ctrl+Alt+w shortcut key and check work as expected well ### Screenshots (if appropriate)   ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: soralee <[email protected]> Closes #1756 from soralee/ZEPPELIN-1804 and squashes the following commits: 92d2a44 [soralee] [ZEPPELIN-1804] Reopen added Link this paragraph to keyboard shortcut Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/14479fd7 Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/14479fd7 Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/14479fd7 Branch: refs/heads/master Commit: 14479fd7a07c0183a620d37db446290789c6da91 Parents: a648746 Author: soralee <[email protected]> Authored: Thu Dec 15 16:32:21 2016 +0900 Committer: Lee moon soo <[email protected]> Committed: Sat Dec 17 07:54:29 2016 -0800 ---------------------------------------------------------------------- .../src/app/notebook/paragraph/paragraph.controller.js | 5 ++++- .../src/components/modal-shortcut/modal-shortcut.html | 11 +++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/zeppelin/blob/14479fd7/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js ---------------------------------------------------------------------- diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js b/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js index 9ef943e..36a7ed6 100644 --- a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js +++ b/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js @@ -556,6 +556,7 @@ $scope.editor.commands.removeCommand('showSettingsMenu'); $scope.editor.commands.bindKey('ctrl-alt-l', null); + $scope.editor.commands.bindKey('ctrl-alt-w', null); // autocomplete on 'ctrl+.' $scope.editor.commands.bindKey('ctrl-.', 'startAutocomplete'); @@ -1092,10 +1093,12 @@ } else { $scope.showTitle($scope.paragraph); } - }else if (keyEvent.ctrlKey && keyEvent.shiftKey && keyCode === 67) { // Ctrl + Alt + c + } else if (keyEvent.ctrlKey && keyEvent.shiftKey && keyCode === 67) { // Ctrl + Alt + c $scope.copyPara('below'); } else if (keyEvent.ctrlKey && keyEvent.altKey && keyCode === 76) { // Ctrl + Alt + l $scope.clearParagraphOutput($scope.paragraph); + } else if (keyEvent.ctrlKey && keyEvent.altKey && keyCode === 87) { // Ctrl + Alt + w + $scope.goToSingleParagraph(); } else { noShortcutDefined = true; } http://git-wip-us.apache.org/repos/asf/zeppelin/blob/14479fd7/zeppelin-web/src/components/modal-shortcut/modal-shortcut.html ---------------------------------------------------------------------- diff --git a/zeppelin-web/src/components/modal-shortcut/modal-shortcut.html b/zeppelin-web/src/components/modal-shortcut/modal-shortcut.html index 26f9cb1..bc64906 100644 --- a/zeppelin-web/src/components/modal-shortcut/modal-shortcut.html +++ b/zeppelin-web/src/components/modal-shortcut/modal-shortcut.html @@ -202,6 +202,17 @@ limitations under the License. <div class="row"> <div class="col-md-4"> <div class="keys"> + <kbd class="kbd-dark">Ctrl</kbd> + <kbd class="kbd-dark">{{ isMac ? 'Option' : 'Alt'}}</kbd> + <kbd class="kbd-dark">w</kbd> + </div> + </div> + <div class="col-md-8"> + Link this paragraph + </div> + </div> + + <div class="row"> + <div class="col-md-4"> + <div class="keys"> <kbd class="kbd-dark">Ctrl</kbd> + <kbd class="kbd-dark">Shift</kbd> + <kbd class="kbd-dark">-</kbd> </div> </div>
