Repository: zeppelin Updated Branches: refs/heads/master 304842a3f -> 82fc4ba25
[ZEPPELIN-1551] Remove the "default" text against interpreters on interpreters screen as it is providing incorrect semantics ### What is this PR for? This PR addresses the incorrect semantics and confusion caused by the "default" text against an interpreter group on interpreters page. The intent of of this tag seems to be informing the user which of the interpreters among a particular group will be used by default if the user doesn't specify any %<interpreter> tag. However, the "default" tag is always tied to the first interpreter of the first interpreter group on the page and isn't displayed for any other interpreter groups; therefore not serving any purpose. It also leads to confusion with the default interpreter bound to a notebook on bindings page. It would be better to remove this default tag from interpreters in order to avoid the confusion. ### What type of PR is it? Bug Fix ### Todos ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1551 ### How should this be tested? Run Zeppelin server. Open Interpreters menu. "default" shouldn't be visible against any interpreter group. ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No ### Screenshots (if appropriate)  Author: Naman Mishra <[email protected]> Closes #1968 from namanmishra91/ZEPPELIN-1551 and squashes the following commits: f9ded1d [Naman Mishra] Remove the "default" text against interpreters on interpreter settings screen as it is providing incorrect semantics. Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/82fc4ba2 Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/82fc4ba2 Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/82fc4ba2 Branch: refs/heads/master Commit: 82fc4ba258d1c212533d11e9c700864e36ae2f87 Parents: 304842a Author: Naman Mishra <[email protected]> Authored: Thu Feb 2 16:28:50 2017 +0530 Committer: Jongyoul Lee <[email protected]> Committed: Wed Feb 8 00:11:09 2017 +0900 ---------------------------------------------------------------------- zeppelin-web/src/app/interpreter/interpreter.html | 1 - 1 file changed, 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/zeppelin/blob/82fc4ba2/zeppelin-web/src/app/interpreter/interpreter.html ---------------------------------------------------------------------- diff --git a/zeppelin-web/src/app/interpreter/interpreter.html b/zeppelin-web/src/app/interpreter/interpreter.html index ed1aa2d..c586814 100644 --- a/zeppelin-web/src/app/interpreter/interpreter.html +++ b/zeppelin-web/src/app/interpreter/interpreter.html @@ -103,7 +103,6 @@ limitations under the License. %<span ng-show="!$parent.$first || $first">{{setting.name}}</span ><span ng-show="(!$parent.$first || $first) && !$first">.</span ><span ng-show="!$first">{{interpreter.name}}</span> - <span ng-show="$parent.$first && $first">(default)</span> </span> </small>
