[zeppelin] branch master updated: [ZEPPELIN-4173] Fixed open note have wrong repl name throws NullPointerException

[liuxun]

This is an automated email from the ASF dual-hosted git repository.

liuxun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/zeppelin.git


The following commit(s) were added to refs/heads/master by this push:
     new 8a30f08  [ZEPPELIN-4173] Fixed open note have wrong repl name throws 
NullPointerException
8a30f08 is described below

commit 8a30f08952acc999085d6ac57fed940179c35dfb
Author: Xun Liu <liu...@apache.org>
AuthorDate: Fri May 31 12:18:49 2019 +0800

    [ZEPPELIN-4173] Fixed open note have wrong repl name throws 
NullPointerException
    
    ### What is this PR for?
    When you open a paragraph with an wrong interpreter name, Will trigger a 
NullPointerException.
    
    ```
    java.lang.NullPointerException
    at 
org.apache.zeppelin.socket.NotebookServer.updateAngularObjectRegistry(NotebookServer.java:658)
    at 
org.apache.zeppelin.socket.NotebookServer.access$200(NotebookServer.java:101)
    at 
org.apache.zeppelin.socket.NotebookServer$5.onSuccess(NotebookServer.java:640)
    at 
org.apache.zeppelin.socket.NotebookServer$5.onSuccess(NotebookServer.java:635)
    at 
org.apache.zeppelin.service.NotebookService.getNote(NotebookService.java:130)
    at 
org.apache.zeppelin.socket.NotebookServer.getNote(NotebookServer.java:634)
    at 
org.apache.zeppelin.socket.NotebookServer.onMessage(NotebookServer.java:296)
    at 
org.apache.zeppelin.socket.NotebookSocket.onWebSocketText(NotebookSocket.java:58)
    at 
org.eclipse.jetty.websocket.common.events.JettyListenerEventDriver.onTextMessage(JettyListenerEventDriver.java:189)
    at 
org.eclipse.jetty.websocket.common.message.SimpleTextMessage.messageComplete(SimpleTextMessage.java:69)
    at 
org.eclipse.jetty.websocket.common.events.AbstractEventDriver.appendMessage(AbstractEventDriver.java:66)
    ```
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-4173
    
    ### How should this be tested?
    * [CI Pass](https://travis-ci.org/liuxunorg/zeppelin/builds/538540857)
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update?
    * Is there breaking changes for older versions?
    * Does this needs documentation?
    
    Author: Xun Liu <liu...@apache.org>
    
    Closes #3373 from liuxunorg/ZEPPELIN-4173 and squashes the following 
commits:
    
    7e29691ca [Xun Liu] Modify LOG level.
    f2f7808a8 [Xun Liu] [ZEPPELIN-4173] Fixed open the note with the wrong repl 
name throw NullPointerException
---
 .../src/main/java/org/apache/zeppelin/socket/NotebookServer.java     | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git 
a/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java 
b/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
index 266cd97..2130b98 100644
--- 
a/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
+++ 
b/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
@@ -652,7 +652,10 @@ public class NotebookServer extends WebSocketServlet
       try {
         interpreterGroup = findInterpreterGroupForParagraph(note, 
paragraph.getId());
       } catch (Exception e) {
-        e.printStackTrace();
+        LOG.warn(e.getMessage(), e);
+      }
+      if (null == interpreterGroup) {
+        return;
       }
       RemoteAngularObjectRegistry registry = (RemoteAngularObjectRegistry)
           interpreterGroup.getAngularObjectRegistry();