[zeppelin] branch master updated: [ZEPPELIN-5459] Unable to change graph setting when paragraph is in RUNNING

[zjffdu]

This is an automated email from the ASF dual-hosted git repository.

zjffdu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/zeppelin.git


The following commit(s) were added to refs/heads/master by this push:
     new 0ec8975  [ZEPPELIN-5459] Unable to change graph setting when paragraph 
is in RUNNING
0ec8975 is described below

commit 0ec89755d3155c254bdf33cb7e9603f10708af65
Author: Jeff Zhang <zjf...@apache.org>
AuthorDate: Wed Jul 14 23:32:18 2021 +0800

    [ZEPPELIN-5459] Unable to change graph setting when paragraph is in RUNNING
    
    ### What is this PR for?
    
    The issue happens in Flink streaming visualization. If I change the graph 
setting when paragraph is in RUNNING, it would be revert back to its original 
setting when backend send data to frontend. The root cause is that zeppelin 
didn't save paragraph setting change when paragraph is in RUNNING.
    
    ### What type of PR is it?
    [Bug Fix ]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-5459
    
    ### How should this be tested?
    *  manually tested
    
    ### Screenshots (if appropriate)
    
    Before
    
    
![before](https://user-images.githubusercontent.com/164491/125650746-193c1a03-0c0a-44d3-8f26-57fbfda5eed7.gif)
    
    After
    
![after](https://user-images.githubusercontent.com/164491/125650760-284b232a-ce4a-4d5f-b637-c2cf1e9bb3e1.gif)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    
    Author: Jeff Zhang <zjf...@apache.org>
    
    Closes #4175 from zjffdu/ZEPPELIN-5459 and squashes the following commits:
    
    6f97efe572 [Jeff Zhang] [ZEPPELIN-5459] Unable to change graph setting when 
paragraph is in RUNNING
---
 zeppelin-web/src/app/notebook/paragraph/result/result.controller.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/zeppelin-web/src/app/notebook/paragraph/result/result.controller.js 
b/zeppelin-web/src/app/notebook/paragraph/result/result.controller.js
index ec74cb9..b51d518 100644
--- a/zeppelin-web/src/app/notebook/paragraph/result/result.controller.js
+++ b/zeppelin-web/src/app/notebook/paragraph/result/result.controller.js
@@ -815,7 +815,7 @@ function ResultCtrl($scope, $rootScope, $route, $window, 
$routeParams, $location
   };
 
   const commitVizConfigChange = function(config, vizId) {
-    if ([ParagraphStatus.RUNNING, 
ParagraphStatus.PENDING].indexOf(paragraph.status) < 0) {
+    if (ParagraphStatus.PENDING !== paragraph.status) {
       let newConfig = angular.copy($scope.config);
       if (!newConfig.graph) {
         newConfig.graph = {};