(zeppelin) branch master updated: [ZEPPELIN-6175] Correction of linter errors in zeppelin-web

[pdallig]

This is an automated email from the ASF dual-hosted git repository.

pdallig pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/zeppelin.git


The following commit(s) were added to refs/heads/master by this push:
     new 53be157c38 [ZEPPELIN-6175] Correction of linter errors in zeppelin-web
53be157c38 is described below

commit 53be157c3850ca1d9327da5e53a1ae189992e1a3
Author: Philipp Dallig <philipp.dal...@gmail.com>
AuthorDate: Wed Apr 16 09:24:48 2025 +0200

    [ZEPPELIN-6175] Correction of linter errors in zeppelin-web
    
    ### What is this PR for?
    Fix our Build
    
    ### What type of PR is it?
    Hot Fix
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-6175
    
    ### How should this be tested?
    * CI
    
    ### Questions:
    * Does the license files need to update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    
    
    Closes #4913 from Reamer/zeppelin_web_linter.
    
    Signed-off-by: Philipp Dallig <philipp.dal...@gmail.com>
---
 zeppelin-web/src/app/notebook/notebook.controller.js | 20 ++++++++++----------
 .../src/app/notebook/notebook.controller.test.js     |  7 ++++---
 .../app/notebook/paragraph/paragraph.controller.js   | 15 ++++++++++-----
 3 files changed, 24 insertions(+), 18 deletions(-)

diff --git a/zeppelin-web/src/app/notebook/notebook.controller.js 
b/zeppelin-web/src/app/notebook/notebook.controller.js
index 4d1abfce01..3b1a13f299 100644
--- a/zeppelin-web/src/app/notebook/notebook.controller.js
+++ b/zeppelin-web/src/app/notebook/notebook.controller.js
@@ -464,21 +464,21 @@ function NotebookCtrl($scope, $route, $routeParams, 
$location, $rootScope,
     $scope.$broadcast('closeTable');
   };
 
-  $scope.toggleAllNumbering = function () {
+  $scope.toggleAllNumbering = function() {
     if ($scope.note.config.numberingToggled) {
-      $scope.$broadcast('setNumbering', false)
+      $scope.$broadcast('setNumbering', false);
     } else {
-      $scope.$broadcast('setNumbering', true)
+      $scope.$broadcast('setNumbering', true);
     }
-    $scope.note.config.numberingToggled = !$scope.note.config.numberingToggled
-    $scope.setConfig()
-  }
+    $scope.note.config.numberingToggled = !$scope.note.config.numberingToggled;
+    $scope.setConfig();
+  };
 
-  $scope.updateParagraphNumbering = function () {
+  $scope.updateParagraphNumbering = function() {
     for (let i = 0; i < $scope.note.paragraphs.length; i++) {
-      $scope.note.paragraphs[i].number = i + 1
+      $scope.note.paragraphs[i].number = i + 1;
     }
-  }
+  };
 
   /**
    * @returns {boolean} true if one more paragraphs are running. otherwise 
return false.
@@ -643,7 +643,7 @@ function NotebookCtrl($scope, $route, $routeParams, 
$location, $rootScope,
     if (removedPara && removedPara.length === 1) {
       addPara(removedPara[0], newIdx);
     }
-    $scope.updateParagraphNumbering()
+    $scope.updateParagraphNumbering();
   });
 
   $scope.$on('updateNote', function(event, name, config, info) {
diff --git a/zeppelin-web/src/app/notebook/notebook.controller.test.js 
b/zeppelin-web/src/app/notebook/notebook.controller.test.js
index 8aa8524feb..e3769daaa9 100644
--- a/zeppelin-web/src/app/notebook/notebook.controller.test.js
+++ b/zeppelin-web/src/app/notebook/notebook.controller.test.js
@@ -38,9 +38,10 @@ describe('Controller: NotebookCtrl', function() {
   });
 
   let functions = ['getCronOptionNameFromValue', 'removeNote', 
'runAllParagraphs', 'saveNote', 'toggleAllEditor',
-    'showAllEditor', 'hideAllEditor', 'toggleAllTable', 'hideAllTable', 
'showAllTable', 'isNoteRunning',
-    'killSaveTimer', 'startSaveTimer', 'setLookAndFeel', 'setCronScheduler', 
'setConfig', 'updateNoteName',
-    'openSetting', 'closeSetting', 'saveSetting', 'toggleSetting'];
+    'showAllEditor', 'hideAllEditor', 'toggleAllTable', 'hideAllTable', 
'toggleAllNumbering',
+    'updateParagraphNumbering', 'showAllTable', 'isNoteRunning', 
'killSaveTimer', 'startSaveTimer',
+    'setLookAndFeel', 'setCronScheduler', 'setConfig', 'updateNoteName', 
'openSetting', 'closeSetting',
+    'saveSetting', 'toggleSetting'];
 
   functions.forEach(function(fn) {
     it('check for scope functions to be defined : ' + fn, function() {
diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js 
b/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
index 3d21fec343..69ee634af0 100644
--- a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
+++ b/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
@@ -155,8 +155,9 @@ function ParagraphCtrl($scope, $rootScope, $route, $window, 
$routeParams, $locat
     noteVarShareService.put($scope.paragraph.id + '_paragraphScope', 
paragraphScope);
 
     initializeDefault($scope.paragraph.config);
-
-    $scope.updateParagraphNumbering();
+    if ($scope.updateParagraphNumbering) {
+      $scope.updateParagraphNumbering();
+    }
   };
 
   $scope.$on('noteRunningStatus', function(event, status) {
@@ -180,7 +181,11 @@ function ParagraphCtrl($scope, $rootScope, $route, 
$window, $routeParams, $locat
     }
 
     if (config.numbering === undefined) {
-      config.numbering = $scope.note.config.numberingToggled
+      if ($scope.note) {
+        config.numbering = $scope.note.config.numberingToggled;
+      } else {
+        config.numbering = false;
+      }
     }
 
     for (let idx in forms) {
@@ -1826,9 +1831,9 @@ function ParagraphCtrl($scope, $rootScope, $route, 
$window, $routeParams, $locat
 
   $scope.$on('setNumbering', function(event, value) {
     if (value) {
-      $scope.showNumbering($scope.paragraph)
+      $scope.showNumbering($scope.paragraph);
     } else {
-      $scope.hideNumbering($scope.paragraph)
+      $scope.hideNumbering($scope.paragraph);
     }
   });