This is an automated email from the ASF dual-hosted git repository.
tbonelee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/zeppelin.git
The following commit(s) were added to refs/heads/master by this push:
new 4a551ed2c0 [ZEPPELIN-6421] Integrate zeppelin-react lint into root
lint script
4a551ed2c0 is described below
commit 4a551ed2c0f7ac7490fe10c89bb4554bd3dc49c6
Author: ChanHo Lee <[email protected]>
AuthorDate: Wed Jun 3 01:08:55 2026 +0900
[ZEPPELIN-6421] Integrate zeppelin-react lint into root lint script
### What is this PR for?
`zeppelin-react` has its own ESLint config with rules at `error` level
(e.g. `<at>typescript-eslint/no-explicit-any`, `react-hooks/exhaustive-deps`),
but its lint script is not wired into the root `npm run lint` of
`zeppelin-web-angular`. As a result, Maven's `npm lint` execution
(`zeppelin-web-angular/pom.xml`) does not catch ESLint violations in
`zeppelin-react`.
### What changes are proposed?
Mirror the existing `build:react` pattern with `lint:react` /
`lint:fix:react` scripts and include them in the root composite `lint` and
`lint:fix` scripts. The `postinstall` hook already installs
`projects/zeppelin-react/node_modules`, so no extra install step is needed.
### What type of PR is it?
Improvement
### Todos
* [x] - Update root lint scripts to include zeppelin-react
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-6421
### How should this be tested?
Run `npm run lint` inside `zeppelin-web-angular/` and confirm that
zeppelin-react ESLint errors are reported.
### Screenshots (if appropriate)
N/A
### Questions:
* Does the licenses files need to update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Closes #5258 from tbonelee/ZEPPELIN-6421-lint-react.
Signed-off-by: ChanHo Lee <[email protected]>
---
zeppelin-web-angular/package.json | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/zeppelin-web-angular/package.json
b/zeppelin-web-angular/package.json
index 3d48881c83..aafb74bdc2 100644
--- a/zeppelin-web-angular/package.json
+++ b/zeppelin-web-angular/package.json
@@ -14,8 +14,10 @@
"build:projects": "npm run build-project:sdk && npm run build-project:vis",
"build-project:sdk": "ng build --project zeppelin-sdk",
"build-project:vis": "ng build --project zeppelin-visualization",
- "lint": "cross-env NODE_OPTIONS='--max-old-space-size=8192' ng lint &&
prettier --check \"**/*.{ts,js,json,css,html}\"",
- "lint:fix": "cross-env NODE_OPTIONS='--max-old-space-size=8192' ng lint
--fix && prettier --write \"**/*.{ts,js,json,css,html}\"",
+ "lint": "cross-env NODE_OPTIONS='--max-old-space-size=8192' ng lint && npm
run lint:react && prettier --check \"**/*.{ts,js,json,css,html}\"",
+ "lint:fix": "cross-env NODE_OPTIONS='--max-old-space-size=8192' ng lint
--fix && npm run lint:fix:react && prettier --write
\"**/*.{ts,js,json,css,html}\"",
+ "lint:react": "cd projects/zeppelin-react && npm run lint",
+ "lint:fix:react": "cd projects/zeppelin-react && npm run lint:fix",
"e2e": "playwright test",
"e2e:fast": "playwright test --project=chromium",
"e2e:ui": "playwright test --ui",
