This is an automated email from the ASF dual-hosted git repository. tbonelee pushed a commit to branch fix-lint in repository https://gitbox.apache.org/repos/asf/zeppelin.git
commit 1007809aa5e11d62bb9bd8c499fbbf1dbcd43ae7 Author: ChanHo Lee <[email protected]> AuthorDate: Wed Jun 3 16:59:01 2026 +0900 [ZEPPELIN-6426] Remove redundant eslint-disable comments in zeppelin-web-angular --- .../zeppelin-sdk/src/interfaces/message-common.interface.ts | 1 - .../zeppelin-sdk/src/interfaces/message-operator.interface.ts | 1 - .../zeppelin-visualization/src/g2-visualization-component-base.ts | 1 - .../projects/zeppelin-visualization/src/table-transformation.ts | 1 - zeppelin-web-angular/src/app/app-http.interceptor.ts | 1 - .../src/app/core/destroy-hook/destroy-hook.component.ts | 1 - .../src/app/core/message-listener/message-listener.ts | 8 ++------ zeppelin-web-angular/src/app/languages/scala.ts | 1 - .../src/app/pages/workspace/share/result/result.component.ts | 1 - zeppelin-web-angular/src/app/services/helium.service.ts | 1 - 10 files changed, 2 insertions(+), 15 deletions(-) diff --git a/zeppelin-web-angular/projects/zeppelin-sdk/src/interfaces/message-common.interface.ts b/zeppelin-web-angular/projects/zeppelin-sdk/src/interfaces/message-common.interface.ts index 2ebbe71f52..dfbaf4bf18 100644 --- a/zeppelin-web-angular/projects/zeppelin-sdk/src/interfaces/message-common.interface.ts +++ b/zeppelin-web-angular/projects/zeppelin-sdk/src/interfaces/message-common.interface.ts @@ -1,4 +1,3 @@ -/* eslint-disable @typescript-eslint/naming-convention */ /* * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. diff --git a/zeppelin-web-angular/projects/zeppelin-sdk/src/interfaces/message-operator.interface.ts b/zeppelin-web-angular/projects/zeppelin-sdk/src/interfaces/message-operator.interface.ts index c1a0c96952..1f8036b393 100644 --- a/zeppelin-web-angular/projects/zeppelin-sdk/src/interfaces/message-operator.interface.ts +++ b/zeppelin-web-angular/projects/zeppelin-sdk/src/interfaces/message-operator.interface.ts @@ -10,7 +10,6 @@ * limitations under the License. */ -/* eslint-disable jsdoc/no-types */ /** * Representation of event type. */ diff --git a/zeppelin-web-angular/projects/zeppelin-visualization/src/g2-visualization-component-base.ts b/zeppelin-web-angular/projects/zeppelin-visualization/src/g2-visualization-component-base.ts index 3a1f3da43c..cc6e01173f 100644 --- a/zeppelin-web-angular/projects/zeppelin-visualization/src/g2-visualization-component-base.ts +++ b/zeppelin-web-angular/projects/zeppelin-visualization/src/g2-visualization-component-base.ts @@ -21,7 +21,6 @@ import { Visualization } from './visualization'; template: '', standalone: false }) -// eslint-disable-next-line @angular-eslint/component-class-suffix export abstract class G2VisualizationComponentBase implements OnDestroy { abstract container: ElementRef<HTMLDivElement>; chart?: G2.Chart | null; diff --git a/zeppelin-web-angular/projects/zeppelin-visualization/src/table-transformation.ts b/zeppelin-web-angular/projects/zeppelin-visualization/src/table-transformation.ts index fcaf559cb5..aa671fcd73 100644 --- a/zeppelin-web-angular/projects/zeppelin-visualization/src/table-transformation.ts +++ b/zeppelin-web-angular/projects/zeppelin-visualization/src/table-transformation.ts @@ -14,7 +14,6 @@ import { GraphConfig } from '@zeppelin/sdk'; import { TableData } from './table-data'; import { Transformation } from './transformation'; -// eslint-disable-next-line @typescript-eslint/no-explicit-any export class TableTransformation extends Transformation { constructor(config: GraphConfig) { super(config); diff --git a/zeppelin-web-angular/src/app/app-http.interceptor.ts b/zeppelin-web-angular/src/app/app-http.interceptor.ts index db003370f9..e3e4f26a4f 100644 --- a/zeppelin-web-angular/src/app/app-http.interceptor.ts +++ b/zeppelin-web-angular/src/app/app-http.interceptor.ts @@ -28,7 +28,6 @@ export class AppHttpInterceptor implements HttpInterceptor { intercept(httpRequest: HttpRequest<any>, next: HttpHandler): Observable<HttpEvent<any>> { let httpRequestUpdated = httpRequest.clone({ withCredentials: true }); if (environment.production) { - // eslint-disable-next-line @typescript-eslint/naming-convention httpRequestUpdated = httpRequest.clone({ setHeaders: { 'X-Requested-With': 'XMLHttpRequest' } }); } return next.handle(httpRequestUpdated).pipe( diff --git a/zeppelin-web-angular/src/app/core/destroy-hook/destroy-hook.component.ts b/zeppelin-web-angular/src/app/core/destroy-hook/destroy-hook.component.ts index 97d15b2d7e..12e7374e9b 100644 --- a/zeppelin-web-angular/src/app/core/destroy-hook/destroy-hook.component.ts +++ b/zeppelin-web-angular/src/app/core/destroy-hook/destroy-hook.component.ts @@ -17,7 +17,6 @@ import { Subject } from 'rxjs'; template: '', standalone: false }) -// eslint-disable-next-line @angular-eslint/component-class-suffix export class DestroyHookComponent implements OnDestroy { readonly destroy$ = new Subject<void>(); diff --git a/zeppelin-web-angular/src/app/core/message-listener/message-listener.ts b/zeppelin-web-angular/src/app/core/message-listener/message-listener.ts index 12897460ae..8e60193593 100644 --- a/zeppelin-web-angular/src/app/core/message-listener/message-listener.ts +++ b/zeppelin-web-angular/src/app/core/message-listener/message-listener.ts @@ -19,7 +19,6 @@ import { Message, MessageReceiveDataTypeMap, ReceiveArgumentsType } from '@zeppe template: '', standalone: false }) -// eslint-disable-next-line @angular-eslint/component-class-suffix export class MessageListenersManager implements OnDestroy { __zeppelinMessageListeners__?: Array<() => void>; __zeppelinMessageListeners$__: Subscriber<unknown> | null = new Subscriber(); @@ -43,18 +42,15 @@ export function MessageListener<K extends keyof MessageReceiveDataTypeMap>(op: K ) { const oldValue = descriptor.value as ReceiveArgumentsType<K>; - // eslint-disable-next-line no-invalid-this const fn = function (this: MessageListenersManager) { - // eslint-disable-next-line no-invalid-this if (!this.__zeppelinMessageListeners$__) { throw new Error('__zeppelinMessageListeners$__ is not defined'); } - // eslint-disable-next-line no-invalid-this + this.__zeppelinMessageListeners$__.add( - // eslint-disable-next-line no-invalid-this this.messageService.receive(op).subscribe(data => { // @ts-ignore - // eslint-disable-next-line no-invalid-this + oldValue.apply(this, [data]); }) ); diff --git a/zeppelin-web-angular/src/app/languages/scala.ts b/zeppelin-web-angular/src/app/languages/scala.ts index 4b8c821055..4930eb05c9 100644 --- a/zeppelin-web-angular/src/app/languages/scala.ts +++ b/zeppelin-web-angular/src/app/languages/scala.ts @@ -232,7 +232,6 @@ export const language = { [/[\/*]/, 'comment.doc'] ], - // eslint-disable-next-line id-blacklist string: [ [/[^\\"]+/, 'string'], [/@escapes/, 'string.escape'], diff --git a/zeppelin-web-angular/src/app/pages/workspace/share/result/result.component.ts b/zeppelin-web-angular/src/app/pages/workspace/share/result/result.component.ts index 85f9715c7f..1b2ef5c9f3 100644 --- a/zeppelin-web-angular/src/app/pages/workspace/share/result/result.component.ts +++ b/zeppelin-web-angular/src/app/pages/workspace/share/result/result.component.ts @@ -596,7 +596,6 @@ export class NotebookParagraphResultComponent implements OnInit, AfterViewInit, this.destroy$.complete(); } - // eslint-disable-next-line @typescript-eslint/no-explicit-any private commitClassicVizConfigChange(configForMode: GraphConfig, mode: string) { if (this.isPending) { return; diff --git a/zeppelin-web-angular/src/app/services/helium.service.ts b/zeppelin-web-angular/src/app/services/helium.service.ts index 84fe126e2f..f120bc120d 100644 --- a/zeppelin-web-angular/src/app/services/helium.service.ts +++ b/zeppelin-web-angular/src/app/services/helium.service.ts @@ -91,7 +91,6 @@ export class HeliumService extends BaseRest { // eslint-disable-next-line @typescript-eslint/no-explicit-any (window as any)._heliumBundles = [] as HeliumBundle[]; availableBundles.forEach(bundle => { - // eslint-disable-next-line no-eval eval(bundle); });
