(zeppelin) branch master updated: [ZEPPELIN-6535] Match table column filter terms literally instead of as regex

[chanholee]

This is an automated email from the ASF dual-hosted git repository.

tbonelee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/zeppelin.git


The following commit(s) were added to refs/heads/master by this push:
     new 09ba0e0139 [ZEPPELIN-6535] Match table column filter terms literally 
instead of as regex
09ba0e0139 is described below

commit 09ba0e0139a58b75cbace12129182b8c7d2ccf90
Author: JangAyeon <67853616+jangay...@users.noreply.github.com>
AuthorDate: Mon Jul 20 23:01:32 2026 +0900

    [ZEPPELIN-6535] Match table column filter terms literally instead of as 
regex
    
    ### What is this PR for?
    Typing a regular-expression metacharacter (for example `[`, `(`, `*`) into 
a Table visualization's per-column
    search box threw an uncaught SyntaxError and silently broke the column 
filter, because the term was compiled as a
    regular expression. In `filterRows()`, each column's filter predicate 
called `String(row[key]).search(value.term)`,
    and `String.prototype.search()` coerces its argument to a RegExp, so the 
raw user-typed term became a pattern;
    benign metacharacters such as `.` or `*` also silently changed the match 
semantics instead of throwing an error.
    
    This PR replaces `.search()` with `String.prototype.includes()`, so the 
term is always matched as a literal
    substring instead of being compiled as a regex. The term is also trimmed 
before matching, so leading/trailing
    whitespace typed into the search box doesn't affect the result.
    
    
    ### What type of PR is it?
    Bug Fix
    
    ### Todos
      - [x] Match table column filter terms literally instead of compiling them 
as a RegExp
    
    ### What is the Jira issue?
    [ZEPPELIN-6535](https://issues.apache.org/jira/browse/ZEPPELIN-6535)
    
    ### How should this be tested?
      - `cd zeppelin-web-angular && npm run lint`
      - Produce a Table result (e.g. run `print("%table 
Name\tValue\nAlice\t10\nBob\t20")` in a `%python` paragraph),
      open a column's filter dropdown (▼ icon) and type `[` into the search 
box: before the fix, filtering breaks with an
      `Invalid regular expression` error in the console and stops updating; 
after the fix it filters literally with no
      error.
      - Type an ordinary substring (e.g. `Ali`): matching behavior is unchanged 
from before the fix.
    
    ### Questions:
    * Does the license files need to update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    
    
    Closes #5320 from JangAyeon/ZEPPELIN-6535.
    
    Signed-off-by: ChanHo Lee <chanho...@apache.org>
---
 .../src/app/visualizations/table/table-visualization.component.ts      | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git 
a/zeppelin-web-angular/src/app/visualizations/table/table-visualization.component.ts
 
b/zeppelin-web-angular/src/app/visualizations/table/table-visualization.component.ts
index 482900644d..63cf65d943 100644
--- 
a/zeppelin-web-angular/src/app/visualizations/table/table-visualization.component.ts
+++ 
b/zeppelin-web-angular/src/app/visualizations/table/table-visualization.component.ts
@@ -209,8 +209,9 @@ export class TableVisualizationComponent implements OnInit {
         sortKeys.push((row: any) => typeCoercion(row[key], value.type));
         sortTypes.push(value.sort);
       }
+      const term = value.term.trim();
       // eslint-disable-next-line @typescript-eslint/no-explicit-any
-      terms.push((row: any) => String(row[key]).search(value.term) !== -1);
+      terms.push((row: any) => String(row[key]).includes(term));
     });
     this.rows = filter(this.tableData.rows, row => terms.every(term => 
term(row)));
     this.rows = orderBy(this.rows, sortKeys, sortTypes);