This is an automated email from the ASF dual-hosted git repository.
tbonelee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/zeppelin.git
The following commit(s) were added to refs/heads/master by this push:
new 904c0898a2 [ZEPPELIN-6489] Fix stale Shiro authentication
documentation links
904c0898a2 is described below
commit 904c0898a2d5e37e2a725b99e8ae2bec982ff509
Author: Lee SuJung <[email protected]>
AuthorDate: Thu Aug 6 11:03:50 2026 +0900
[ZEPPELIN-6489] Fix stale Shiro authentication documentation links
### What is this PR for?
The Shiro authentication docs URL referenced in `conf/shiro.ini.template`
and in the Kerberos/Knox authentication filter error messages no longer
resolves. The stale link has three defects: it uses `http://` instead of
`https://` (template only), the path is missing the `setup/` segment, and the
file name is missing an underscore (`shiroauthentication.html` →
`shiro_authentication.html`).
This PR updates all three pointers to the current docs address, which is
published from `docs/setup/security/shiro_authentication.md`:
https://zeppelin.apache.org/docs/latest/setup/security/shiro_authentication.html
The surrounding comment/message text is unchanged. One line in
`KnoxAuthenticationFilter` is re-wrapped to keep the longer URL within the
100-character checkstyle limit.
### What type of PR is it?
Documentation
### Todos
* [x] Update the stale URL in `conf/shiro.ini.template`,
`KerberosAuthenticationFilter` and `KnoxAuthenticationFilter`
### What is the Jira issue?
* [ZEPPELIN-6489](https://issues.apache.org/jira/browse/ZEPPELIN-6489)
### How should this be tested?
No code behavior changes — the URLs appear only in a config template
comment and log messages, so no unit tests are added.
* Confirm the source page exists at
`docs/setup/security/shiro_authentication.md`
* Confirm no stale variants remain:
```
rg -n
"shiroauthentication|docs/latest/security/shiro|http://zeppelin.apache.org/docs/latest/security";
conf zeppelin-server
```
* Open
https://zeppelin.apache.org/docs/latest/setup/security/shiro_authentication.html
and confirm it loads (verified: HTTP 200)
### Screenshots (if appropriate)
N/A
### Questions:
* Does the license files need to update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Closes #5361 from xhaktm00/ZEPPELIN-6489.
Signed-off-by: ChanHo Lee <[email protected]>
---
conf/shiro.ini.template | 2 +-
.../java/org/apache/zeppelin/realm/jwt/KnoxAuthenticationFilter.java | 4 ++--
.../apache/zeppelin/realm/kerberos/KerberosAuthenticationFilter.java | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/conf/shiro.ini.template b/conf/shiro.ini.template
index 24b18e2710..c60f278d14 100644
--- a/conf/shiro.ini.template
+++ b/conf/shiro.ini.template
@@ -30,7 +30,7 @@ user3 = password4, role2
#activeDirectoryRealm = org.apache.zeppelin.realm.ActiveDirectoryGroupRealm
#activeDirectoryRealm.systemUsername = userNameA
-#use either systemPassword or hadoopSecurityCredentialPath, more details in
http://zeppelin.apache.org/docs/latest/security/shiroauthentication.html
+#use either systemPassword or hadoopSecurityCredentialPath, more details in
https://zeppelin.apache.org/docs/latest/setup/security/shiro_authentication.html
#activeDirectoryRealm.systemPassword = passwordA
#activeDirectoryRealm.hadoopSecurityCredentialPath =
jceks://file/user/zeppelin/zeppelin.jceks
#activeDirectoryRealm.searchBase = CN=Users,DC=SOME_GROUP,DC=COMPANY,DC=COM
diff --git
a/zeppelin-server/src/main/java/org/apache/zeppelin/realm/jwt/KnoxAuthenticationFilter.java
b/zeppelin-server/src/main/java/org/apache/zeppelin/realm/jwt/KnoxAuthenticationFilter.java
index e280090824..593cbbd050 100644
---
a/zeppelin-server/src/main/java/org/apache/zeppelin/realm/jwt/KnoxAuthenticationFilter.java
+++
b/zeppelin-server/src/main/java/org/apache/zeppelin/realm/jwt/KnoxAuthenticationFilter.java
@@ -68,8 +68,8 @@ public class KnoxAuthenticationFilter extends
FormAuthenticationFilter {
} else {
LOGGER.error(
"Looks like this filter is enabled without enabling KnoxJwtRealm,
please refer"
- + " to
https://zeppelin.apache.org/docs/latest/security/shiroauthentication.html";
- + "#knox-sso");
+ + " to https://zeppelin.apache.org/docs/latest/setup/security/";
+ + "shiro_authentication.html#knox-sso");
}
}
return accessAllowed;
diff --git
a/zeppelin-server/src/main/java/org/apache/zeppelin/realm/kerberos/KerberosAuthenticationFilter.java
b/zeppelin-server/src/main/java/org/apache/zeppelin/realm/kerberos/KerberosAuthenticationFilter.java
index 0f628356d1..4e96ab92bb 100644
---
a/zeppelin-server/src/main/java/org/apache/zeppelin/realm/kerberos/KerberosAuthenticationFilter.java
+++
b/zeppelin-server/src/main/java/org/apache/zeppelin/realm/kerberos/KerberosAuthenticationFilter.java
@@ -76,8 +76,8 @@ public class KerberosAuthenticationFilter extends
PassThruAuthenticationFilter {
kerberosRealm.doKerberosAuth(request, response, filterChain);
} else {
LOGGER.error("Looks like this filter is enabled without enabling
KerberosRealm, please refer"
- + " to
https://zeppelin.apache.org/docs/latest/security/shiroauthentication.html";
- + "#kerberos-auth");
+ + " to
https://zeppelin.apache.org/docs/latest/setup/security/shiro_authentication.html";
+ + "#http-spnego-authentication");
}
}
}
