Repository: incubator-zeppelin Updated Branches: refs/heads/master ab138b81e -> ba67a3a10
change runNote from event to function call When using events, we can't guarantee that the paragraphs will be executed in order, so we need to loop through the paragraphs and make them run. The back-end is already taking care of execution of query in parallel or in order of call, this allows us to send the front-end calls to backend in order. Author: Damien Corneau <[email protected]> Closes #171 from corneadoug/fix/runAllParagraphsOrder and squashes the following commits: 6b5ecc8 [Damien Corneau] change runNote from event to function call Project: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/commit/ba67a3a1 Tree: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/tree/ba67a3a1 Diff: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/diff/ba67a3a1 Branch: refs/heads/master Commit: ba67a3a1021fe816bb4a94c462c94bf635173dd2 Parents: ab138b8 Author: Damien Corneau <[email protected]> Authored: Tue Jul 28 17:35:13 2015 +0900 Committer: Lee moon soo <[email protected]> Committed: Mon Aug 3 05:08:29 2015 +0900 ---------------------------------------------------------------------- zeppelin-web/src/app/notebook/notebook.controller.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/ba67a3a1/zeppelin-web/src/app/notebook/notebook.controller.js ---------------------------------------------------------------------- diff --git a/zeppelin-web/src/app/notebook/notebook.controller.js b/zeppelin-web/src/app/notebook/notebook.controller.js index 6286da6..420435d 100644 --- a/zeppelin-web/src/app/notebook/notebook.controller.js +++ b/zeppelin-web/src/app/notebook/notebook.controller.js @@ -71,7 +71,9 @@ angular.module('zeppelinWebApp').controller('NotebookCtrl', function($scope, $ro $scope.runNote = function() { var result = confirm('Run all paragraphs?'); if (result) { - $scope.$broadcast('runParagraph'); + _.forEach($scope.note.paragraphs, function(n, key) { + angular.element('#' + n.id + '_paragraphColumn_main').scope().runParagraph(n.text); + }); } };
