This is an automated email from the ASF dual-hosted git repository. abesto pushed a commit to branch dont-sign-snapshots in repository https://gitbox.apache.org/repos/asf/incubator-zipkin-brave-karaf.git
commit af6ca7a151475731a70954708f757a25fecd2750 Author: Christian Schneider <[email protected]> AuthorDate: Thu Dec 8 18:35:20 2016 +0100 First version of features and test --- .gitignore | 3 + brave-features/.classpath | 36 +++++ brave-features/pom.xml | 80 +++++++++++ brave-features/src/main/resources/features.xml | 43 ++++++ brave-features/target/classes/features.xml | 43 ++++++ brave-itests/.classpath | 31 +++++ brave-itests/.gitignore | 1 + brave-itests/pom.xml | 153 +++++++++++++++++++++ .../java/io/zipkin/brave/itests/BraveTest.java | 79 +++++++++++ brave-itests/src/test/resources/exam.properties | 2 + brave-itests/src/test/resources/logback.xml | 25 ++++ brave-itests/test.log | 12 ++ pom.xml | 4 +- 13 files changed, 511 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index 32858aa..acd2dc3 100644 --- a/.gitignore +++ b/.gitignore @@ -10,3 +10,6 @@ # virtual machine crash logs, see http://www.java.com/en/download/help/error_hotspot.xml hs_err_pid* + +.project +.settings diff --git a/brave-features/.classpath b/brave-features/.classpath new file mode 100644 index 0000000..fae1a2b --- /dev/null +++ b/brave-features/.classpath @@ -0,0 +1,36 @@ +<?xml version="1.0" encoding="UTF-8"?> +<classpath> + <classpathentry kind="src" output="target/classes" path="src/main/java"> + <attributes> + <attribute name="optional" value="true"/> + <attribute name="maven.pomderived" value="true"/> + </attributes> + </classpathentry> + <classpathentry excluding="**" kind="src" output="target/classes" path="src/main/resources"> + <attributes> + <attribute name="maven.pomderived" value="true"/> + </attributes> + </classpathentry> + <classpathentry kind="src" output="target/test-classes" path="src/test/java"> + <attributes> + <attribute name="optional" value="true"/> + <attribute name="maven.pomderived" value="true"/> + </attributes> + </classpathentry> + <classpathentry excluding="**" kind="src" output="target/test-classes" path="src/test/resources"> + <attributes> + <attribute name="maven.pomderived" value="true"/> + </attributes> + </classpathentry> + <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-1.8"> + <attributes> + <attribute name="maven.pomderived" value="true"/> + </attributes> + </classpathentry> + <classpathentry kind="con" path="org.eclipse.m2e.MAVEN2_CLASSPATH_CONTAINER"> + <attributes> + <attribute name="maven.pomderived" value="true"/> + </attributes> + </classpathentry> + <classpathentry kind="output" path="target/classes"/> +</classpath> diff --git a/brave-features/pom.xml b/brave-features/pom.xml new file mode 100644 index 0000000..2a1bb0f --- /dev/null +++ b/brave-features/pom.xml @@ -0,0 +1,80 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + + Copyright 2016 The OpenZipkin Authors + + Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except + in compliance with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software distributed under the License + is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + or implied. See the License for the specific language governing permissions and limitations under + the License. + +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>io.zipkin.brave.karaf</groupId> + <artifactId>brave-karaf-parent</artifactId> + <version>1.0.0-SNAPSHOT</version> + <relativePath>../pom.xml</relativePath> + </parent> + <artifactId>brave-features</artifactId> + <packaging>pom</packaging> + + <properties> + <main.basedir>${project.basedir}/..</main.basedir> + </properties> + + <build> + <resources> + <resource> + <directory>src/main/resources</directory> + <filtering>true</filtering> + </resource> + </resources> + <plugins> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-resources-plugin</artifactId> + <version>2.7</version> + <executions> + <execution> + <id>filter</id> + <phase>generate-resources</phase> + <goals> + <goal>resources</goal> + </goals> + </execution> + </executions> + </plugin> + <plugin> + <groupId>org.codehaus.mojo</groupId> + <artifactId>build-helper-maven-plugin</artifactId> + <version>1.7</version> + <executions> + <execution> + <id>attach-artifacts</id> + <phase>package</phase> + <goals> + <goal>attach-artifact</goal> + </goals> + <configuration> + <artifacts> + <artifact> + <file>target/classes/features.xml</file> + <type>xml</type> + <classifier>features</classifier> + </artifact> + </artifacts> + </configuration> + </execution> + </executions> + </plugin> + </plugins> + </build> +</project> diff --git a/brave-features/src/main/resources/features.xml b/brave-features/src/main/resources/features.xml new file mode 100644 index 0000000..2b70909 --- /dev/null +++ b/brave-features/src/main/resources/features.xml @@ -0,0 +1,43 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + + Copyright 2016 The OpenZipkin Authors + + Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except + in compliance with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software distributed under the License + is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + or implied. See the License for the specific language governing permissions and limitations under + the License. + +--> +<features name="brave" xmlns="http://karaf.apache.org/xmlns/features/v1.2.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://karaf.apache.org/xmlns/features/v1.2.0 http://karaf.apache.org/xmlns/features/v1.2.0";> + + <repository>mvn:org.apache.cxf.karaf/apache-cxf/3.1.8/xml/features</repository> + + <feature name="brave-core"> + <bundle dependency="true">mvn:io.zipkin.java/zipkin/${zipkin.version}</bundle> + <bundle dependency="true">mvn:io.zipkin.reporter/zipkin-reporter/${zipkin.reporter.version}</bundle> + <bundle>mvn:io.zipkin.reporter/zipkin-sender-urlconnection/${zipkin.reporter.version}</bundle> + <bundle>mvn:io.zipkin.brave/brave-core/${brave.version}</bundle> + </feature> + + <feature name="brave-kafka"> + <feature>brave-core</feature> + <bundle dependency="true">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.kafka-clients/0.8.2.2_1</bundle> + <bundle>mvn:io.zipkin.reporter/zipkin-sender-kafka08/${zipkin.reporter.version}</bundle> + </feature> + + <feature name="brave-jaxrs2"> + <feature>brave-core</feature> + <bundle dependency="true">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.javax-inject/1_2</bundle> + <bundle dependency="true">mvn:io.zipkin.brave/brave-http/${brave.version}</bundle> + <bundle>mvn:io.zipkin.brave/brave-jaxrs2/${brave.version}</bundle> + </feature> + +</features> \ No newline at end of file diff --git a/brave-features/target/classes/features.xml b/brave-features/target/classes/features.xml new file mode 100644 index 0000000..dbde578 --- /dev/null +++ b/brave-features/target/classes/features.xml @@ -0,0 +1,43 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + + Copyright 2016 The OpenZipkin Authors + + Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except + in compliance with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software distributed under the License + is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + or implied. See the License for the specific language governing permissions and limitations under + the License. + +--> +<features name="brave" xmlns="http://karaf.apache.org/xmlns/features/v1.2.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://karaf.apache.org/xmlns/features/v1.2.0 http://karaf.apache.org/xmlns/features/v1.2.0";> + + <repository>mvn:org.apache.cxf.karaf/apache-cxf/3.1.8/xml/features</repository> + + <feature name="brave-core"> + <bundle dependency="true">mvn:io.zipkin.java/zipkin/1.16.0</bundle> + <bundle dependency="true">mvn:io.zipkin.reporter/zipkin-reporter/${zipkin.reporter.version}</bundle> + <bundle>mvn:io.zipkin.reporter/zipkin-sender-urlconnection/${zipkin.reporter.version}</bundle> + <bundle>mvn:io.zipkin.brave/brave-core/3.16.0</bundle> + </feature> + + <feature name="brave-kafka"> + <feature>brave-core</feature> + <bundle dependency="true">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.kafka-clients/0.8.2.2_1</bundle> + <bundle>mvn:io.zipkin.reporter/zipkin-sender-kafka08/${zipkin.reporter.version}</bundle> + </feature> + + <feature name="brave-jaxrs2"> + <feature>brave-core</feature> + <bundle dependency="true">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.javax-inject/1_2</bundle> + <bundle dependency="true">mvn:io.zipkin.brave/brave-http/3.16.0</bundle> + <bundle>mvn:io.zipkin.brave/brave-jaxrs2/3.16.0</bundle> + </feature> + +</features> \ No newline at end of file diff --git a/brave-itests/.classpath b/brave-itests/.classpath new file mode 100644 index 0000000..b2acffc --- /dev/null +++ b/brave-itests/.classpath @@ -0,0 +1,31 @@ +<?xml version="1.0" encoding="UTF-8"?> +<classpath> + <classpathentry kind="src" output="target/classes" path="src/main/java"> + <attributes> + <attribute name="optional" value="true"/> + <attribute name="maven.pomderived" value="true"/> + </attributes> + </classpathentry> + <classpathentry kind="src" output="target/test-classes" path="src/test/java"> + <attributes> + <attribute name="optional" value="true"/> + <attribute name="maven.pomderived" value="true"/> + </attributes> + </classpathentry> + <classpathentry excluding="**" kind="src" output="target/test-classes" path="src/test/resources"> + <attributes> + <attribute name="maven.pomderived" value="true"/> + </attributes> + </classpathentry> + <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-1.7"> + <attributes> + <attribute name="maven.pomderived" value="true"/> + </attributes> + </classpathentry> + <classpathentry kind="con" path="org.eclipse.m2e.MAVEN2_CLASSPATH_CONTAINER"> + <attributes> + <attribute name="maven.pomderived" value="true"/> + </attributes> + </classpathentry> + <classpathentry kind="output" path="target/classes"/> +</classpath> diff --git a/brave-itests/.gitignore b/brave-itests/.gitignore new file mode 100644 index 0000000..b83d222 --- /dev/null +++ b/brave-itests/.gitignore @@ -0,0 +1 @@ +/target/ diff --git a/brave-itests/pom.xml b/brave-itests/pom.xml new file mode 100644 index 0000000..158a9a7 --- /dev/null +++ b/brave-itests/pom.xml @@ -0,0 +1,153 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + + Copyright 2016 The OpenZipkin Authors + + Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except + in compliance with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software distributed under the License + is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + or implied. See the License for the specific language governing permissions and limitations under + the License. + +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>io.zipkin.brave.karaf</groupId> + <artifactId>brave-karaf-parent</artifactId> + <version>1.0.0-SNAPSHOT</version> + <relativePath>../pom.xml</relativePath> + </parent> + <artifactId>brave-itests</artifactId> + <version>0.0.1-SNAPSHOT</version> + + <properties> + <pax.exam.version>4.5.0</pax.exam.version> + <pax.url.version>2.1.0</pax.url.version> + <logback.version>1.0.4</logback.version> + <slf4j.version>1.7.4</slf4j.version> + <karaf.version>4.0.7</karaf.version> + <junit.version>4.12</junit.version> + <main.basedir>${project.basedir}/..</main.basedir> + </properties> + + <dependencies> + <dependency> + <groupId>io.zipkin.brave</groupId> + <artifactId>brave-core</artifactId> + <version>${brave.version}</version> + </dependency> + + <dependency> + <groupId>junit</groupId> + <artifactId>junit</artifactId> + <scope>test</scope> + </dependency> + + <!-- Pax Exam Dependencies --> + <dependency> + <groupId>org.ops4j.pax.exam</groupId> + <artifactId>pax-exam-junit4</artifactId> + <version>${pax.exam.version}</version> + <scope>test</scope> + </dependency> + <dependency> + <groupId>org.ops4j.pax.exam</groupId> + <artifactId>pax-exam-invoker-junit</artifactId> + <version>${pax.exam.version}</version> + <scope>test</scope> + </dependency> + + <!-- Karaf Container --> + <dependency> + <groupId>org.ops4j.pax.exam</groupId> + <artifactId>pax-exam-container-karaf</artifactId> + <version>${pax.exam.version}</version> + <scope>test</scope> + </dependency> + <dependency> + <groupId>org.ops4j.pax.exam</groupId> + <artifactId>pax-exam-inject</artifactId> + <version>${pax.exam.version}</version> + <scope>test</scope> + </dependency> + <dependency> + <groupId>org.ops4j.pax.exam</groupId> + <artifactId>pax-exam-extender-service</artifactId> + <version>${pax.exam.version}</version> + <scope>test</scope> + </dependency> + + <!-- Preferred link because it does not require an mvn url handler implicitely. --> + <dependency> + <groupId>org.ops4j.pax.exam</groupId> + <artifactId>pax-exam-link-mvn</artifactId> + <version>${pax.exam.version}</version> + <scope>test</scope> + </dependency> + + <dependency> + <groupId>org.ops4j.pax.exam</groupId> + <artifactId>pax-exam-link-assembly</artifactId> + <version>${pax.exam.version}</version> + <scope>test</scope> + </dependency> + + <dependency> + <groupId>ch.qos.logback</groupId> + <artifactId>logback-core</artifactId> + <version>${logback.version}</version> + <scope>test</scope> + </dependency> + + <dependency> + <groupId>ch.qos.logback</groupId> + <artifactId>logback-classic</artifactId> + <version>${logback.version}</version> + <scope>test</scope> + </dependency> + + <dependency> + <groupId>org.apache.geronimo.specs</groupId> + <artifactId>geronimo-atinject_1.0_spec</artifactId> + <version>1.0</version> + <scope>provided</scope> + </dependency> + + <dependency> + <groupId>org.osgi</groupId> + <artifactId>org.osgi.core</artifactId> + <version>4.3.1</version> + <scope>provided</scope> + </dependency> + + <dependency> + <groupId>org.osgi</groupId> + <artifactId>org.osgi.compendium</artifactId> + <version>4.3.1</version> + <scope>provided</scope> + </dependency> + + <!-- framework to test with --> + <dependency> + <groupId>org.apache.karaf.features</groupId> + <artifactId>standard</artifactId> + <version>${karaf.version}</version> + <type>xml</type> + <classifier>features</classifier> + <scope>test</scope> + </dependency> + <dependency> + <groupId>org.apache.karaf.features</groupId> + <artifactId>org.apache.karaf.features.core</artifactId> + <version>${karaf.version}</version> + <scope>test</scope> + </dependency> + </dependencies> + +</project> diff --git a/brave-itests/src/test/java/io/zipkin/brave/itests/BraveTest.java b/brave-itests/src/test/java/io/zipkin/brave/itests/BraveTest.java new file mode 100644 index 0000000..580bf4c --- /dev/null +++ b/brave-itests/src/test/java/io/zipkin/brave/itests/BraveTest.java @@ -0,0 +1,79 @@ +/** + * Copyright 2016 The OpenZipkin Authors + * + * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except + * in compliance with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + */ + +package io.zipkin.brave.itests; + +import static org.hamcrest.core.IsEqual.equalTo; +import static org.ops4j.pax.exam.CoreOptions.maven; +import static org.ops4j.pax.exam.karaf.options.KarafDistributionOption.configureConsole; +import static org.ops4j.pax.exam.karaf.options.KarafDistributionOption.features; +import static org.ops4j.pax.exam.karaf.options.KarafDistributionOption.karafDistributionConfiguration; +import static org.ops4j.pax.exam.karaf.options.KarafDistributionOption.keepRuntimeFolder; +import static org.ops4j.pax.exam.karaf.options.KarafDistributionOption.logLevel; + +import java.util.ArrayList; +import java.util.List; + +import com.github.kristofa.brave.Brave; +import org.junit.Assert; +import org.junit.Test; +import org.junit.runner.RunWith; +import org.ops4j.pax.exam.Configuration; +import org.ops4j.pax.exam.Option; +import org.ops4j.pax.exam.junit.PaxExam; +import org.ops4j.pax.exam.karaf.options.LogLevelOption.LogLevel; +import org.ops4j.pax.exam.options.MavenArtifactUrlReference; +import org.ops4j.pax.exam.options.MavenUrlReference; +import org.ops4j.pax.exam.spi.reactors.ExamReactorStrategy; +import org.ops4j.pax.exam.spi.reactors.PerClass; +import zipkin.Span; +import zipkin.reporter.Reporter; + +@RunWith(PaxExam.class) +@ExamReactorStrategy(PerClass.class) +public class BraveTest { + List<Object> spans = new ArrayList<>(); + + @Configuration + public static Option[] configuration() throws Exception { + MavenArtifactUrlReference karaf = maven().groupId("org.apache.karaf").artifactId("apache-karaf") + .type("zip").version("4.0.7"); + MavenUrlReference brave = maven().groupId("net.lr.brave.osgi").artifactId("brave-features").type("xml") + .classifier("features").version("0.0.1-SNAPSHOT"); + return new Option[] // + { + karafDistributionConfiguration().frameworkUrl(karaf).useDeployFolder(false), + configureConsole().ignoreLocalConsole(), // + logLevel(LogLevel.INFO), // + keepRuntimeFolder(), // + features(brave, "brave-core") + }; + } + + @Test + public void shouldHaveBundleContext() { + Reporter<Span> local = new Reporter<Span>() { + + @Override + public void report(Span span) { + spans.add(span); + } + }; + Brave brave = new Brave.Builder().reporter(local).build(); + brave.localTracer().startNewSpan("test", "testop"); + brave.localTracer().finishSpan(); + Assert.assertThat(1, equalTo(spans.size())); + } + +} diff --git a/brave-itests/src/test/resources/exam.properties b/brave-itests/src/test/resources/exam.properties new file mode 100644 index 0000000..4936b4a --- /dev/null +++ b/brave-itests/src/test/resources/exam.properties @@ -0,0 +1,2 @@ +pax.exam.logging = none +pax.exam.service.timeout = 5000 diff --git a/brave-itests/src/test/resources/logback.xml b/brave-itests/src/test/resources/logback.xml new file mode 100644 index 0000000..c35d3ca --- /dev/null +++ b/brave-itests/src/test/resources/logback.xml @@ -0,0 +1,25 @@ +<?xml version="1.0" encoding="UTF-8"?> +<configuration> + + <!-- log to System.out on console --> + <appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender"> + <encoder> + <pattern>%d{HH:mm:ss.SSS} [%thread] %-5level %logger{36} - %msg%n</pattern> + </encoder> + </appender> + + <!-- log to file test.log --> + <appender name="TEST_LOG" class="ch.qos.logback.core.FileAppender"> + <file>test.log</file> + <encoder> + <pattern>%d{HH:mm:ss.SSS} [%thread] %-5level %logger{36} - %msg%n</pattern> + </encoder> + </appender> + + <root level="INFO"> + <appender-ref ref="STDOUT" /> + <appender-ref ref="TEST_LOG" /> + </root> + <logger name="org.ops4j.pax.exam" level="INFO" /> + +</configuration> \ No newline at end of file diff --git a/brave-itests/test.log b/brave-itests/test.log new file mode 100644 index 0000000..816493b --- /dev/null +++ b/brave-itests/test.log @@ -0,0 +1,12 @@ +18:31:51.236 [main] INFO o.o.pax.exam.spi.DefaultExamSystem - Pax Exam System (Version: 4.5.0) created. +18:31:51.259 [main] INFO o.o.pax.exam.junit.impl.ProbeRunner - creating PaxExam runner for class io.zipkin.brave.itests.BraveTest +18:31:51.296 [main] INFO o.o.pax.exam.junit.impl.ProbeRunner - running test class io.zipkin.brave.itests.BraveTest +18:31:51.887 [main] INFO o.o.p.e.k.c.i.KarafTestContainer - Wait for test container to finish its initialization [ RelativeTimeout value = 180000 ] +18:31:51.887 [main] INFO o.o.p.e.r.c.RemoteBundleContextClient - Waiting for remote bundle context.. on 21000 name: 8e7b7902-4f23-4c53-b6ce-f0e9726bb409 timout: [ RelativeTimeout value = 180000 ] +18:31:55.829 [main] INFO o.o.p.e.spi.reactors.ReactorManager - suite finished +18:34:24.681 [main] INFO o.o.pax.exam.spi.DefaultExamSystem - Pax Exam System (Version: 4.5.0) created. +18:34:24.706 [main] INFO o.o.pax.exam.junit.impl.ProbeRunner - creating PaxExam runner for class io.zipkin.brave.itests.BraveTest +18:34:24.748 [main] INFO o.o.pax.exam.junit.impl.ProbeRunner - running test class io.zipkin.brave.itests.BraveTest +18:34:25.317 [main] INFO o.o.p.e.k.c.i.KarafTestContainer - Wait for test container to finish its initialization [ RelativeTimeout value = 180000 ] +18:34:25.318 [main] INFO o.o.p.e.r.c.RemoteBundleContextClient - Waiting for remote bundle context.. on 21000 name: a46215d8-24fb-41ee-b43b-6abd9c827388 timout: [ RelativeTimeout value = 180000 ] +18:34:29.355 [main] INFO o.o.p.e.spi.reactors.ReactorManager - suite finished diff --git a/pom.xml b/pom.xml index d31d811..fe8f27a 100644 --- a/pom.xml +++ b/pom.xml @@ -23,6 +23,8 @@ <packaging>pom</packaging> <modules> + <module>brave-features</module> + <module>brave-itests</module> </modules> <properties> @@ -37,6 +39,7 @@ <license-maven-plugin.version>2.11</license-maven-plugin.version> + <brave.version>3.16.0</brave.version> <zipkin.version>1.16.0</zipkin.version> <zipkin-reporter.version>0.6.7</zipkin-reporter.version> @@ -116,7 +119,6 @@ <dependency> <groupId>io.zipkin.java</groupId> <artifactId>zipkin</artifactId> - <version>${zipkin.version}</version> </dependency> <!-- don't worry. auto-* are source retention, not runtime -->
