jcchavezs commented on issue #69: decide if we want to validate thrift on pull request or not URL: https://github.com/apache/incubator-zipkin-api/issues/69#issuecomment-487821516 I would not add validation for now as we are not changing it. Even if change I would not try to validate or until the necessity of a big change. tir. 30. apr. 2019, 05:39 skrev Adrian Cole <[email protected]>: > fwiw we've never validated thrift on pull request, and incidentally until > today even swagger validation was busted! > > Now, we validate swagger and proto on pull request. > > — > You are receiving this because you are on a team that was mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-zipkin-api/issues/69#issuecomment-487812659>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAXOYAWSNXUD6LANPM4C5NTPS65NTANCNFSM4HJIIVOQ> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
