adriancole commented on a change in pull request #2502: Adding storage-throttle
module to address "over capacity" issues
URL: https://github.com/apache/incubator-zipkin/pull/2502#discussion_r279985384
##########
File path: zipkin-collector/core/src/main/java/zipkin2/collector/Collector.java
##########
@@ -227,7 +228,13 @@ RuntimeException doError(String message, Throwable e) {
message = format("%s due to %s(%s)", message,
e.getClass().getSimpleName(), error);
warn(message, e);
}
- return new RuntimeException(message, e);
Review comment:
PS unraveling the old code is something I will do out-of-band. I think some
should change, but yeah there is impact to error formatting, which some is done
at the wrong place. Here only main thing is to not pass ExecutionException
without unwrapping it properly. if that's done before formatting logic, should
be ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
