adriancole opened a new pull request #2552: Fixes logging and metrics for collectors URL: https://github.com/apache/incubator-zipkin/pull/2552 Before, we were inconsistent about incrementing metrics, and in worst case, we double-incremented. This adds tests for the messaging based collectors and backfills tests to make the base Collector class 100% coverage. Separately, we have recently changed our web endpoint to produce its own error messages to the client. In other words, we no longer rely on (often unnecessary) wrapping of exceptions to correct the message being sent back. This changes the logic around message formatting so it is only used when logging is enabled.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
