Logic-32 commented on a change in pull request #2552: Fixes logging and metrics
for collectors
URL: https://github.com/apache/incubator-zipkin/pull/2552#discussion_r280003649
##########
File path: zipkin-collector/core/src/main/java/zipkin2/collector/Collector.java
##########
@@ -110,34 +119,46 @@ public void accept(List<Span> spans, Callback<Void>
callback) {
}
try {
+ // adding a separate callback intentionally decouples collection from
storage
record(sampled, acceptSpansCallback(sampled));
callback.onSuccess(null);
- } catch (RuntimeException e) {
- callback.onError(errorStoringSpans(sampled, e));
- return;
+ } catch (RuntimeException | Error e) {
+ handleStorageError(spans, e, callback);
Review comment:
Interesting point! Would it be worthwhile to separate the `...accept()`
call from `enqueue()` for the sake of error messaging? I'm not exactly sold on
the difference being worthwhile at the moment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
