worldtiki commented on a change in pull request #9: Update Pitchfork extension
to mention Kafka and RabbitMq
URL:
https://github.com/apache/incubator-zipkin-website/pull/9#discussion_r281092228
##########
File path: pages/extensions_choices.md
##########
@@ -47,7 +47,7 @@ Listed below are alternative backends that accept Zipkin
format. Some use the sa
- When `SPAN_STORAGE_TYPE=kafka` and `zipkin-thrift`, Jaeger reads Zipkin
v1 thrift encoded span messages from a Kafka topic.
- Note: The above is a [deprecated
practice](https://github.com/openzipkin/zipkin/tree/master/zipkin-collector/kafka#legacy-encoding)
in Zipkin. Most instrumentation bundle multiple spans per message in v2 format.
- [Pitchfork](https://github.com/HotelsDotCom/pitchfork)
- - Pitchfork exposes the same HTTP POST endpoints Zipkin does
+ - Pitchfork exposes the same HTTP POST endpoints Zipkin does. It can also
consume spans from a Kafka topic of a RabbitMq queue.
Review comment:
What the heck was I thinking when I wrote this? Thanks for the review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
