adriancole commented on issue #2461: re-implement scribe over armeria URL: https://github.com/apache/incubator-zipkin/issues/2461#issuecomment-489864871 ps the biggest problem with scribe is that twitter still use it, and there is no other implementation in finagle besides scribe. I ask them every year about this always same. this implies techdebt https://github.com/twitter/finagle/tree/develop/finagle-zipkin-scribe @trustin how ugly would an http adapter be anyway? We only need to support what we support now, which is only the following definition and no fancy transport (only normal TCP). It would be nice to know what it would feel like even if the code to do it lives (and dies) here. ``` @ThriftService("Scribe") public interface Scribe { @ThriftMethod(value = "Log") ListenableFuture<ResultCode> log(@ThriftField(value = 1) List<LogEntry> messages); enum ResultCode { OK(0), TRY_LATER(1); final int value; ResultCode(int value) { this.value = value; } @ThriftEnumValue public int value() { return value; } } @ThriftStruct(value = "LogEntry") final class LogEntry { @ThriftField(value = 1) public String category; @ThriftField(value = 2) public String message; } } ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
