tacigar commented on a change in pull request #2577: Change file suffix .js to
.jsx
URL: https://github.com/apache/incubator-zipkin/pull/2577#discussion_r282742486
##########
File path: zipkin-lens/src/components/MiniTimeline/index.js
##########
@@ -14,55 +14,4 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-import PropTypes from 'prop-types';
-import React from 'react';
-
-import MiniTimelineGraph from './MiniTimelineGraph';
-import MiniTimelineLabel from './MiniTimelineLabel';
-import MiniTimelineSlider from './MiniTimelineSlider';
-import { detailedTraceSummaryPropTypes } from '../../prop-types';
-
-const defaultNumTimeMarkers = 5;
-
-const propTypes = {
- startTs: PropTypes.number.isRequired,
- endTs: PropTypes.number.isRequired,
- traceSummary: detailedTraceSummaryPropTypes.isRequired,
- onStartAndEndTsChange: PropTypes.func.isRequired,
-};
-
-const MiniTimeline = ({
- startTs, endTs, traceSummary, onStartAndEndTsChange,
-}) => {
- const { spans, duration } = traceSummary;
- if (spans.length <= 1) {
- return null;
- }
-
- return (
- <div className="mini-timeline">
- <MiniTimelineLabel
- numTimeMarkers={defaultNumTimeMarkers}
- duration={duration}
- />
- <MiniTimelineGraph
- spans={spans}
- duration={duration}
- startTs={startTs}
- endTs={endTs}
- onStartAndEndTsChange={onStartAndEndTsChange}
- numTimeMarkers={defaultNumTimeMarkers}
- />
- <MiniTimelineSlider
- duration={duration}
- startTs={startTs}
- endTs={endTs}
- onStartAndEndTsChange={onStartAndEndTsChange}
- />
- </div>
- );
-};
-
-MiniTimeline.propTypes = propTypes;
-
-export default MiniTimeline;
Review comment:
The above code is moved to `MiniTimeline.jsx`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
