adriancole commented on issue #2579: Benchmark bytes / bytebuffer, protobuf vs zipkin vs wire. URL: https://github.com/apache/incubator-zipkin/pull/2579#issuecomment-491302237 @anuraaga leaning towards not changing anything I guess you mean changing the parsing approach? If so, I would say even if we wanted to, it can wait. we are allocating more per request in parsing than necessary, but it is hard to tell the impact without looking at the total stuff allocated along the way. Regardless, I think we should merge your benchmarks so it can be picked up later.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
