adriancole removed a comment on issue #2584: Adds cheap string encoding for IpV4 path used in protobuf URL: https://github.com/apache/incubator-zipkin/pull/2584#issuecomment-491495757 found another spot in latest commit which closes the gap even more ``` ProtoCodecBenchmarks.bytes_protobufDecoder:bytes_protobufDecoder·p0.99 sample 1953.710 us/op ProtoCodecBenchmarks.bytes_protobufDecoder:·gc.alloc.rate.norm sample 15 2023206.265 ± 32.203 B/op ProtoCodecBenchmarks.bytes_wireDecoder:bytes_wireDecoder·p0.99 sample 2351.104 us/op ProtoCodecBenchmarks.bytes_wireDecoder:·gc.alloc.rate.norm sample 15 2435408.568 ± 53.612 B/op ProtoCodecBenchmarks.bytes_zipkinDecoder:bytes_zipkinDecoder·p0.99 sample 2002.944 us/op ProtoCodecBenchmarks.bytes_zipkinDecoder:·gc.alloc.rate.norm sample 15 2095165.920 ± 33.639 B/op ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
