adriancole commented on a change in pull request #2594: Improves description for AUTOCOMPLETE_KEYS URL: https://github.com/apache/incubator-zipkin/pull/2594#discussion_r284181558
########## File path: zipkin-server/README.md ########## @@ -154,7 +154,7 @@ Defaults to true * `QUERY_LOOKBACK`: How many milliseconds queries can look back from endTs; Defaults to 24 hours (two daily buckets: one for today and one for yesterday) * `STORAGE_TYPE`: SpanStore implementation: one of `mem`, `mysql`, `cassandra`, `elasticsearch` * `COLLECTOR_SAMPLE_RATE`: Percentage of traces to retain, defaults to always sample (1.0). -* `AUTOCOMPLETE_KEYS`: list of span tag keys which will be returned by the `/api/v2/autocompleteTags` endpoint +* `AUTOCOMPLETE_KEYS`: list of span tag keys which will be returned by the `/api/v2/autocompleteTags` endpoint; Tag keys should be comma separated, e.g. "request_id,instance_id,env" Review comment: request_id is a bad example because it is high cardinality. otherwise looks good ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
