adriancole commented on issue #2632: Fix ThrottledStorageComponent not passing through health check URL: https://github.com/apache/incubator-zipkin/pull/2632#issuecomment-503126004 Ack. thanks for mentioning but I think this is the better optimization On Mon, Jun 17, 2019, 10:52 PM lambcode <notificati...@github.com> wrote: > *@lambcode* commented on this pull request. > ------------------------------ > > In zipkin/src/main/java/zipkin2/Component.java > <https://github.com/apache/incubator-zipkin/pull/2632#discussion_r294338327> > : > > > @@ -38,6 +38,11 @@ public CheckResult check() { > return CheckResult.OK; > } > > + public String name() { > > I'm okay with this change. Just want to note that the name reported by the > health endpoint will change for some components. E.g "InMemoryStorage" will > become "InMemoryStorage{traceCount=123}" > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-zipkin/pull/2632?email_source=notifications&email_token=AAAPVVZGH6BBYGEBMVAWI2DP26QMFA5CNFSM4HYITGW2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB3XQYQY#discussion_r294338327>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAAPVV2NR3UUXXDGREW2CUDP26QMFANCNFSM4HYITGWQ> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
