tacigar commented on a change in pull request #2633: [WIP] Use Material-UI for GlobalSearch component URL: https://github.com/apache/incubator-zipkin/pull/2633#discussion_r295104396
########## File path: zipkin-lens/src/colors/index.js ########## @@ -11,20 +11,16 @@ * or implied. See the License for the specific language governing permissions and limitations under * the License. */ -import { getInitialUnit } from './ConditionDuration'; +import { createMuiTheme } from '@material-ui/core/styles'; -describe('getInitialUnit', () => { - it('should return "s" when value is divisible by 1.000.000', () => { - expect(getInitialUnit(1000000)).toBe('s'); - }); - it('should return "ms" when value is divisible by 1.000', () => { - expect(getInitialUnit(1500000)).toBe('ms'); - expect(getInitialUnit(1000)).toBe('ms'); - }); +export const primaryColor = '#6a9fb5'; Review comment: This color may be Zipkin color. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services