Author: fpj Date: Mon Sep 22 10:11:35 2014 New Revision: 1626721 URL: http://svn.apache.org/r1626721 Log: BOOKKEEPER-786: Fix Findbugs Error In Codahale Stats Provider (sijie via fpj)
Modified: zookeeper/bookkeeper/trunk/CHANGES.txt zookeeper/bookkeeper/trunk/bookkeeper-stats-providers/codahale-metrics-provider/src/main/java/org/apache/bookkeeper/stats/CodahaleMetricsProvider.java Modified: zookeeper/bookkeeper/trunk/CHANGES.txt URL: http://svn.apache.org/viewvc/zookeeper/bookkeeper/trunk/CHANGES.txt?rev=1626721&r1=1626720&r2=1626721&view=diff ============================================================================== --- zookeeper/bookkeeper/trunk/CHANGES.txt (original) +++ zookeeper/bookkeeper/trunk/CHANGES.txt Mon Sep 22 10:11:35 2014 @@ -246,6 +246,8 @@ Trunk (unreleased changes) BOOKKEEPER-779: jmx reporter for codahale metrics provider (ivank via sijie) + BOOKKEEPER-786: Fix Findbugs Error In Codahale Stats Provider (sijie via fpj) + hedwig-server: BOOKKEEPER-601: readahead cache size isn't updated correctly (sijie via fpj) Modified: zookeeper/bookkeeper/trunk/bookkeeper-stats-providers/codahale-metrics-provider/src/main/java/org/apache/bookkeeper/stats/CodahaleMetricsProvider.java URL: http://svn.apache.org/viewvc/zookeeper/bookkeeper/trunk/bookkeeper-stats-providers/codahale-metrics-provider/src/main/java/org/apache/bookkeeper/stats/CodahaleMetricsProvider.java?rev=1626721&r1=1626720&r2=1626721&view=diff ============================================================================== --- zookeeper/bookkeeper/trunk/bookkeeper-stats-providers/codahale-metrics-provider/src/main/java/org/apache/bookkeeper/stats/CodahaleMetricsProvider.java (original) +++ zookeeper/bookkeeper/trunk/bookkeeper-stats-providers/codahale-metrics-provider/src/main/java/org/apache/bookkeeper/stats/CodahaleMetricsProvider.java Mon Sep 22 10:11:35 2014 @@ -115,7 +115,7 @@ public class CodahaleMetricsProvider imp } if (!Strings.isNullOrEmpty(jmxDomain)) { LOG.info("Configuring stats with jmx"); - jmx = JmxReporter.forRegistry(metrics) + jmx = JmxReporter.forRegistry(getMetrics()) .inDomain(jmxDomain) .convertRatesTo(TimeUnit.SECONDS) .convertDurationsTo(TimeUnit.MILLISECONDS)