Repository: zookeeper Updated Branches: refs/heads/branch-3.5 434fecb11 -> 285c9f410
ZOOKEEPER-2746: remove the check on the new leader after a dynamic re⦠â¦config operation. This check might not always hold because the nominated leader could fail to lead the quorum during sync phase - for example if sync time out [when waiting for quorum ack](https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/quorum/Leader.java#L1232). I am thinking we should just remove this instead of fixing it because the nominated leader is not an interface level contract / guarantee but a best effort / implementation level details. Author: Michael Han <[email protected]> Reviewers: Alexander Shraer <[email protected]> Closes #213 from hanm/ZOOKEEPER-2746 Project: http://git-wip-us.apache.org/repos/asf/zookeeper/repo Commit: http://git-wip-us.apache.org/repos/asf/zookeeper/commit/285c9f41 Tree: http://git-wip-us.apache.org/repos/asf/zookeeper/tree/285c9f41 Diff: http://git-wip-us.apache.org/repos/asf/zookeeper/diff/285c9f41 Branch: refs/heads/branch-3.5 Commit: 285c9f4102ee38e8547b74b8f3bfea6d92be0b60 Parents: 434fecb Author: Michael Han <[email protected]> Authored: Tue Apr 4 17:02:55 2017 -0700 Committer: Michael Han <[email protected]> Committed: Mon Apr 17 16:48:06 2017 -0700 ---------------------------------------------------------------------- src/java/test/org/apache/zookeeper/test/ReconfigTest.java | 1 - 1 file changed, 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/zookeeper/blob/285c9f41/src/java/test/org/apache/zookeeper/test/ReconfigTest.java ---------------------------------------------------------------------- diff --git a/src/java/test/org/apache/zookeeper/test/ReconfigTest.java b/src/java/test/org/apache/zookeeper/test/ReconfigTest.java index c4658ca..49de3f7 100644 --- a/src/java/test/org/apache/zookeeper/test/ReconfigTest.java +++ b/src/java/test/org/apache/zookeeper/test/ReconfigTest.java @@ -678,7 +678,6 @@ public class ReconfigTest extends ZKTestCase implements DataCallback{ Assert.assertTrue(qu.getPeer(leaderIndex).peer.getQuorumAddress() .getPort() == newQuorumPort); - Assert.assertTrue(getLeaderId(qu) != leaderIndex); // the leader changed joiningServers.clear();
