[zookeeper] branch master updated: ZOOKEEPER-3341: Remove Superfluous ByteBuffer Duplicate

[andor]

This is an automated email from the ASF dual-hosted git repository.

andor pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/zookeeper.git


The following commit(s) were added to refs/heads/master by this push:
     new 6dc61ad  ZOOKEEPER-3341: Remove Superfluous ByteBuffer Duplicate
6dc61ad is described below

commit 6dc61adbe41c712fbce930e598b3556da54e0667
Author: Beluga Behr <dam6...@gmail.com>
AuthorDate: Tue Apr 9 16:08:29 2019 +0200

    ZOOKEEPER-3341: Remove Superfluous ByteBuffer Duplicate
    
    Author: Beluga Behr <dam6...@gmail.com>
    
    Reviewers: an...@apache.org
    
    Closes #881 from BELUGABEHR/ZOOKEEPER-3341
---
 .../java/org/apache/zookeeper/server/quorum/QuorumCnxManager.java    | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git 
a/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumCnxManager.java
 
b/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumCnxManager.java
index 4675333..35f3529 100644
--- 
a/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumCnxManager.java
+++ 
b/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumCnxManager.java
@@ -1192,10 +1192,9 @@ public class QuorumCnxManager {
                     /**
                      * Allocates a new ByteBuffer to receive the message
                      */
-                    byte[] msgArray = new byte[length];
+                    final byte[] msgArray = new byte[length];
                     din.readFully(msgArray, 0, length);
-                    ByteBuffer message = ByteBuffer.wrap(msgArray);
-                    addToRecvQueue(new Message(message.duplicate(), sid));
+                    addToRecvQueue(new Message(ByteBuffer.wrap(msgArray), 
sid));
                 }
             } catch (Exception e) {
                 LOG.warn("Connection broken for id " + sid + ", my id = "