This is an automated email from the ASF dual-hosted git repository.
andor pushed a commit to branch branch-3.5
in repository https://gitbox.apache.org/repos/asf/zookeeper.git
The following commit(s) were added to refs/heads/branch-3.5 by this push:
new 034226b ZOOKEEPER-3494: 3.5) remove unnecessary broad netty-all
dependency
034226b is described below
commit 034226ba5f98bcdf5deb6b1f91d471ade4467209
Author: Norbert Kalmar <[email protected]>
AuthorDate: Tue Aug 6 12:59:58 2019 +0200
ZOOKEEPER-3494: 3.5) remove unnecessary broad netty-all dependency
Currently netty-all is a 4MB dependency.
Using netty-handler (429KB) and netty-transport-native-epoll (115KB) brings
it down to about 1/8 in size.
Author: Norbert Kalmar <nkalmaryahoo.com>
Reviewers: Enrico Olivelli <eolivelligmail.com>, Tamás Pénzes, Michael Han
<hanmapache.org>
Closes #1039 from nkalmar/ZK-3494
Author: Norbert Kalmar <[email protected]>
Reviewers: [email protected]
Closes #1041 from nkalmar/branch-3.5
---
ivy.xml | 7 +++++--
pom.xml | 7 ++++++-
zookeeper-server/pom.xml | 6 +++++-
3 files changed, 16 insertions(+), 4 deletions(-)
diff --git a/ivy.xml b/ivy.xml
index 0e8359d..c189df4 100644
--- a/ivy.xml
+++ b/ivy.xml
@@ -60,8 +60,11 @@
<dependency org="org.apache.yetus" name="audience-annotations"
rev="${audience-annotations.version}"/>
- <dependency org="io.netty" name="netty-all" conf="default"
rev="${netty.version}">
- <artifact name="netty-all" type="jar" conf="default"/>
+ <dependency org="io.netty" name="netty-handler" conf="default"
rev="${netty.version}">
+ <artifact name="netty-handler" type="jar" conf="default"/>
+ </dependency>
+ <dependency org="io.netty" name="netty-transport-native-epoll"
conf="default" rev="${netty.version}">
+ <artifact name="netty-transport-native-epoll" type="jar" conf="default"/>
</dependency>
<dependency org="junit" name="junit" rev="${junit.version}"
conf="test->default"/>
diff --git a/pom.xml b/pom.xml
index 13a8c21..015e324 100755
--- a/pom.xml
+++ b/pom.xml
@@ -392,7 +392,12 @@
</dependency>
<dependency>
<groupId>io.netty</groupId>
- <artifactId>netty-all</artifactId>
+ <artifactId>netty-handler</artifactId>
+ <version>${netty.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-transport-native-epoll</artifactId>
<version>${netty.version}</version>
</dependency>
<dependency>
diff --git a/zookeeper-server/pom.xml b/zookeeper-server/pom.xml
index 4c8fba8..0f41bd1 100755
--- a/zookeeper-server/pom.xml
+++ b/zookeeper-server/pom.xml
@@ -66,7 +66,11 @@
</dependency>
<dependency>
<groupId>io.netty</groupId>
- <artifactId>netty-all</artifactId>
+ <artifactId>netty-handler</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-transport-native-epoll</artifactId>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
