[zookeeper] branch branch-3.5 updated: ZOOKEEPER-3708: Move Logging Code into Logging Guard in Learner

[andor]

This is an automated email from the ASF dual-hosted git repository.

andor pushed a commit to branch branch-3.5
in repository https://gitbox.apache.org/repos/asf/zookeeper.git


The following commit(s) were added to refs/heads/branch-3.5 by this push:
     new 58eca43  ZOOKEEPER-3708: Move Logging Code into Logging Guard in 
Learner
58eca43 is described below

commit 58eca43a201362167eb33b501f452bc37d36b5f3
Author: David Mollitor <dmolli...@apache.org>
AuthorDate: Mon Feb 3 04:30:41 2020 +0100

    ZOOKEEPER-3708: Move Logging Code into Logging Guard in Learner
    
    Author: David Mollitor <dmolli...@apache.org>
    
    Reviewers: eolive...@apache.org, an...@apache.org
    
    Closes #1240 from belugabehr/ZOOKEEPER-3708
    
    (cherry picked from commit 68e1f7d4c54429caa74441c7444ef1fe0f75867c)
    Signed-off-by: Andor Molnar <an...@apache.org>
---
 .../src/main/java/org/apache/zookeeper/server/quorum/Learner.java | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git 
a/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Learner.java
 
b/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Learner.java
index 3b739ac..1c964f2 100644
--- 
a/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Learner.java
+++ 
b/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Learner.java
@@ -157,11 +157,11 @@ public class Learner {
         synchronized (leaderIs) {
             leaderIs.readRecord(pp, "packet");
         }
-        long traceMask = ZooTrace.SERVER_PACKET_TRACE_MASK;
-        if (pp.getType() == Leader.PING) {
-            traceMask = ZooTrace.SERVER_PING_TRACE_MASK;
-        }
         if (LOG.isTraceEnabled()) {
+            final long traceMask =
+                (pp.getType() == Leader.PING) ? ZooTrace.SERVER_PING_TRACE_MASK
+                    : ZooTrace.SERVER_PACKET_TRACE_MASK;
+
             ZooTrace.logQuorumPacket(LOG, traceMask, 'i', pp);
         }
     }