[zookeeper] branch branch-3.7.0 updated: ZOOKEEPER-4200: Widen latency window in WatcherCleanerTest

[eolivelli]

This is an automated email from the ASF dual-hosted git repository.

eolivelli pushed a commit to branch branch-3.7.0
in repository https://gitbox.apache.org/repos/asf/zookeeper.git


The following commit(s) were added to refs/heads/branch-3.7.0 by this push:
     new 184fb98  ZOOKEEPER-4200: Widen latency window in WatcherCleanerTest
184fb98 is described below

commit 184fb984c08c7b3b8dba291ad529b80b8a073ac7
Author: Damien Diederen <d...@crosstwine.com>
AuthorDate: Wed Feb 17 20:18:55 2021 +0100

    ZOOKEEPER-4200: Widen latency window in WatcherCleanerTest
    
    `WatcherCleanerTest` performs latency checks which fail when outside of a 
20+Xms window.  Before this patch, X was 5ms—whereas 30+ms is frequently seen 
on an i5 Mac Mini running macOS Catalina.
    
    This "dumb" patch just widens the window to 20ms, which makes it "work on 
my machine," but could obviously still fail in a loaded environment or VM.
    
    Author: Damien Diederen <d...@crosstwine.com>
    
    Reviewers: Enrico Olivelli <eolive...@apache.org>, Mate Szalay-Beko 
<sy...@apache.org>
    
    Closes #1592 from ztzg/ZOOKEEPER-4200-widen-latency-window
    
    (cherry picked from commit d8ff555339b054fbcf6ea6767357e8bf8c7af2c5)
    Signed-off-by: Enrico Olivelli <eolive...@datastax.com>
---
 .../apache/zookeeper/server/watch/WatcherCleanerTest.java  | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git 
a/zookeeper-server/src/test/java/org/apache/zookeeper/server/watch/WatcherCleanerTest.java
 
b/zookeeper-server/src/test/java/org/apache/zookeeper/server/watch/WatcherCleanerTest.java
index ec05f14..9ed145a 100644
--- 
a/zookeeper-server/src/test/java/org/apache/zookeeper/server/watch/WatcherCleanerTest.java
+++ 
b/zookeeper-server/src/test/java/org/apache/zookeeper/server/watch/WatcherCleanerTest.java
@@ -162,13 +162,13 @@ public class WatcherCleanerTest extends ZKTestCase {
 
         assertEquals(3L, values.get("cnt_dead_watchers_cleaner_latency"));
 
-        //Each latency should be a little over 20 ms, allow 5 ms deviation
-        assertEquals(20D, (Double) 
values.get("avg_dead_watchers_cleaner_latency"), 5);
-        assertEquals(20D, ((Long) 
values.get("min_dead_watchers_cleaner_latency")).doubleValue(), 5);
-        assertEquals(20D, ((Long) 
values.get("max_dead_watchers_cleaner_latency")).doubleValue(), 5);
-        assertEquals(20D, ((Long) 
values.get("p50_dead_watchers_cleaner_latency")).doubleValue(), 5);
-        assertEquals(20D, ((Long) 
values.get("p95_dead_watchers_cleaner_latency")).doubleValue(), 5);
-        assertEquals(20D, ((Long) 
values.get("p99_dead_watchers_cleaner_latency")).doubleValue(), 5);
+        //Each latency should be a little over 20 ms, allow 20 ms deviation
+        assertEquals(20D, (Double) 
values.get("avg_dead_watchers_cleaner_latency"), 20);
+        assertEquals(20D, ((Long) 
values.get("min_dead_watchers_cleaner_latency")).doubleValue(), 20);
+        assertEquals(20D, ((Long) 
values.get("max_dead_watchers_cleaner_latency")).doubleValue(), 20);
+        assertEquals(20D, ((Long) 
values.get("p50_dead_watchers_cleaner_latency")).doubleValue(), 20);
+        assertEquals(20D, ((Long) 
values.get("p95_dead_watchers_cleaner_latency")).doubleValue(), 20);
+        assertEquals(20D, ((Long) 
values.get("p99_dead_watchers_cleaner_latency")).doubleValue(), 20);
     }
 
 }