This is an automated email from the ASF dual-hosted git repository.
tison pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/zookeeper.git
The following commit(s) were added to refs/heads/master by this push:
new e08cc2a78 ZOOKEEPER-4718: Removing unnecessary heap memory allocation
in serialization to help reduce GC pressure (#2031)
e08cc2a78 is described below
commit e08cc2a782982964a57651f179a468b19e2e6010
Author: Yan Zhao <[email protected]>
AuthorDate: Fri Jul 7 09:55:30 2023 +0800
ZOOKEEPER-4718: Removing unnecessary heap memory allocation in
serialization to help reduce GC pressure (#2031)
---
.../src/main/java/org/apache/zookeeper/server/util/SerializeUtils.java | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
a/zookeeper-server/src/main/java/org/apache/zookeeper/server/util/SerializeUtils.java
b/zookeeper-server/src/main/java/org/apache/zookeeper/server/util/SerializeUtils.java
index ba91faaf8..e38772f00 100644
---
a/zookeeper-server/src/main/java/org/apache/zookeeper/server/util/SerializeUtils.java
+++
b/zookeeper-server/src/main/java/org/apache/zookeeper/server/util/SerializeUtils.java
@@ -175,11 +175,12 @@ public class SerializeUtils {
if (request == null || request.getHdr() == null) {
return null;
}
- byte[] data = new byte[32];
+ byte[] data;
try {
data = Util.marshallTxnEntry(request.getHdr(), request.getTxn(),
request.getTxnDigest());
} catch (IOException e) {
LOG.error("This really should be impossible", e);
+ data = new byte[32];
}
return data;
}