This is an automated email from the ASF dual-hosted git repository.
andor pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/zookeeper.git
The following commit(s) were added to refs/heads/master by this push:
new f13bd7149 ZOOKEEPER-4859: Fix openssl gencerts failure due to too long
hostname in github ci (#2186)
f13bd7149 is described below
commit f13bd714903e06fb045930bfbeffa5b5f18e0528
Author: Kezhu Wang <[email protected]>
AuthorDate: Fri Sep 20 00:00:55 2024 +0800
ZOOKEEPER-4859: Fix openssl gencerts failure due to too long hostname in
github ci (#2186)
Reviewers: anmolnar
Author: kezhuw
Closes #2186 from kezhuw/ZOOKEEPER-4859
---
.github/workflows/ci.yaml | 7 +++++++
zookeeper-client/zookeeper-client-c/tests/zkServer.sh | 5 ++++-
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index 658684870..5d220e693 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -86,6 +86,13 @@ jobs:
name: failsafe-reports-${{ matrix.profile.name }}
path: ./**/target/failsafe-reports/
if-no-files-found: ignore
+ - name: Upload cppunit test logs
+ if: ${{ failure() }}
+ uses: actions/upload-artifact@v3
+ with:
+ name: cppunit-logs-${{ matrix.profile.name }}
+ path: ./zookeeper-client/zookeeper-client-c/target/c/TEST-*.txt
+ if-no-files-found: ignore
typo-check:
name: Typo Check
# only run on pull requests because of security reasons
diff --git a/zookeeper-client/zookeeper-client-c/tests/zkServer.sh
b/zookeeper-client/zookeeper-client-c/tests/zkServer.sh
index f98b4058c..7505bf3a8 100755
--- a/zookeeper-client/zookeeper-client-c/tests/zkServer.sh
+++ b/zookeeper-client/zookeeper-client-c/tests/zkServer.sh
@@ -183,7 +183,10 @@ start|startClean|startRequireSASLAuth|startCleanReadOnly)
mkdir -p "${certs_dir}"
cp ${tests_dir}/../ssl/gencerts.sh "${certs_dir}/" > /dev/null
cd ${certs_dir} > /dev/null
- ./gencerts.sh > ./gencerts.stdout 2> ./gencerts.stderr
+ # GitHub is providing us hostnames with more than 64 characters now.
+ # And there are no cppunit tests do hostname verification currently,
+ # so we could set CN to arbitrary hostname for now.
+ ./gencerts.sh tests.zookeeper.apache.org > ./gencerts.stdout 2>
./gencerts.stderr
cd - > /dev/null
