This is an automated email from the ASF dual-hosted git repository.
andor pushed a commit to branch branch-3.9
in repository https://gitbox.apache.org/repos/asf/zookeeper.git
The following commit(s) were added to refs/heads/branch-3.9 by this push:
new 562298853 ZOOKEEPER-4293: Bump netty to 4.1.113.Final, remove
syncUninterruptibly (#1917)
562298853 is described below
commit 5622988532246e4ff382e59f9014057fe05f2554
Author: Michael Edgar <[email protected]>
AuthorDate: Thu Sep 19 15:31:51 2024 -0400
ZOOKEEPER-4293: Bump netty to 4.1.113.Final, remove syncUninterruptibly
(#1917)
Reviewers: anmolnar, kezhuw
Author: MikeEdgar
Closes #1917 from MikeEdgar/ZOOKEEPER-4293
---
pom.xml | 2 +-
.../src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java | 2 +-
.../java/org/apache/zookeeper/server/quorum/UnifiedServerSocket.java | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/pom.xml b/pom.xml
index 43bb32b26..f3fa126a2 100644
--- a/pom.xml
+++ b/pom.xml
@@ -559,7 +559,7 @@
<mockito.version>4.9.0</mockito.version>
<hamcrest.version>2.2</hamcrest.version>
<commons-cli.version>1.5.0</commons-cli.version>
- <netty.version>4.1.105.Final</netty.version>
+ <netty.version>4.1.113.Final</netty.version>
<jetty.version>9.4.53.v20231009</jetty.version>
<jackson.version>2.15.2</jackson.version>
<jline.version>2.14.6</jline.version>
diff --git
a/zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
b/zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
index 5b82c37f9..32379e74c 100755
---
a/zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
+++
b/zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
@@ -203,7 +203,7 @@ public class ClientCnxnSocketNetty extends ClientCnxnSocket
{
connectFuture = null;
}
if (channel != null) {
- channel.close().syncUninterruptibly();
+ channel.close();
channel = null;
}
} finally {
diff --git
a/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/UnifiedServerSocket.java
b/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/UnifiedServerSocket.java
index 387a6c7d7..c101e9e2d 100644
---
a/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/UnifiedServerSocket.java
+++
b/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/UnifiedServerSocket.java
@@ -255,7 +255,7 @@ public class UnifiedServerSocket extends ServerSocket {
bytesRead = 0;
}
- if (bytesRead == litmus.length &&
SslHandler.isEncrypted(Unpooled.wrappedBuffer(litmus))) {
+ if (bytesRead == litmus.length &&
SslHandler.isEncrypted(Unpooled.wrappedBuffer(litmus), false)) {
try {
sslSocket = x509Util.createSSLSocket(prependableSocket,
litmus);
} catch (X509Exception e) {