Dear Wiki user, You have subscribed to a wiki page or wiki category on "Hadoop Wiki" for change notification.
The "Hive/HowToCommit" page has been changed by AshishThusoo. The comment on this change is: Copied and modified Hadoop HowToCommit page and adapted it to Hive HowToCommit.. http://wiki.apache.org/hadoop/Hive/HowToCommit -------------------------------------------------- New page: = Guide for Hive Committers = This page contains guidelines for committers of the Apache Hadoop Hive project. == New committers == New committers are encouraged to first read Apache's generic committer documentation: * [[http://www.apache.org/dev/new-committers-guide.html|Apache New Committer Guide]] * [[http://www.apache.org/dev/committers.html|Apache Committer FAQ]] The first act of a new core committer is typically to add their name to the [[http://hadoop.apache.org/core/credits.html|credits]] page. This requires changing the XML source in http://svn.apache.org/repos/asf/hadoop/core/site/author/src/documentation/content/xdocs/credits.xml. Once done, update the Hive website as described [[#Documentation|here]]. == Review == Hive committers should, as often as possible, attempt to review patches submitted by others. Ideally every submitted patch will get reviewed by a committer within a few days. If a committer reviews a patch they've not authored, and believe it to be of sufficient quality, then they can commit the patch, otherwise the patch should be cancelled with a clear explanation for why it was rejected. The list of submitted patches is in the [[https://issues.apache.org/jira/secure/IssueNavigator.jspa?sorter/field=updated&sorter/order=DESC|Hive Patches]]. This is ordered by time of last modification. Committers should scan the list from top-to-bottom, looking for patches that they feel qualified to review and possibly commit. For non-trivial changes, it is best to get another committer to review your own patches before commit. Use "Submit Patch" like other contributors, and then wait for a "+1" from another committer before committing. == Reject == Patches should be rejected which do not adhere to the guidelines in HowToContribute. Committers should always be polite to contributors and try to instruct and encourage them to contribute better patches. If a committer wishes to improve an unacceptable patch, then it should first be rejected, and a new patch should be attached by the committer for review. == Commit == When you commit a patch, please: 1. Add an entry in CHANGES.txt, at the end of the appropriate section. This should include the Jira issue id, and the name of the contributor. 1. Include the Jira issue id in the commit message, along with a short description of the change and the name of the contributor if it is not you. Be sure to get the issue id right, as this causes Jira to link to the change in Subversion (use the issue's "All" tab to see these). 1. Resolve the issue as fixed, thanking the contributor. Always set the "Fix Version" at this point, but please only set a single fix version, the earliest release in which the change will appear. 1. Use the -E option to make sure that empty files are removed during the commit. <<Anchor(Documentation)>> ==== Committing Documentation ==== Hive's official documentation is authored using [[http://forrest.apache.org/|Forrest]]. To commit documentation changes you must have Forrest installed and the {{{forrest}}} executable on your {{{$PATH}}}. Note that the current version (0.8) doesn't work properly with Java 6, use Java 5 instead. Documentation is of two types: 1. End-user documentation, versioned with releases; and, 1. The website. This is maintained separately in subversion, republished as it is changed. To commit end-user documentation changes to trunk or a branch, ask the user to submit only changes made to the *.xml files in {{{src/docs}}}. Apply that patch, run {{{ant docs}}} to generate the html, and then commit. End-user documentation is only published to the web when releases are made, as described in HowToRelease. To commit changes to the website and re-publish them: {{{ svn co https://svn.apache.org/repos/asf/hadoop/hive/site cd site ant firefox publish/index.html # preview the changes svn stat # check for new pages svn add # add any new pages svn commit ssh people.apache.org cd /www/hadoop.apache.org/hive svn up }}} Changes to website (''via svn up'') might take upto an hour to be reflected on hadoop site. == Backporting commits to previous branches == If a patch needs to be backported to previous branches, follow these steps. 1. Commit the changes to trunk and note down the revision number, say 4001. (Revision number is displayed as response to your ''svn commit'' command). 2. Check out the desired branch and execute this command from the root directory. {{{ svn merge -r 4000:4001 https://svn.apache.org/repos/asf/hadoop/hive/trunk . svn commit }}} == Dialog == Committers should hang out in the ##hive room on irc.freenode.net for real-time discussions. However any substantive discussion (as with any off-list project-related discussion) should be re-iterated in Jira or on the developer list.
