Dear Wiki user, You have subscribed to a wiki page or wiki category on "Hadoop Wiki" for change notification.
The "Hive/HowToContribute" page has been changed by CarlSteinbach. http://wiki.apache.org/hadoop/Hive/HowToContribute?action=diff&rev1=33&rev2=34 -------------------------------------------------- [[Hive/GettingStarted/EclipseSetup|How to set up Eclipse for Hive development]] == Making Changes == - Before you start, send a message to the [[http://hadoop.apache.org/hive/mailing_lists.html#Developers|Hive developer mailing list]], or file a bug report in [[https://issues.apache.org/jira/browse/HIVE|Jira]]. Describe your proposed changes and check that they fit in with what others are doing and have planned for the project. Be patient, it may take folks a while to understand your requirements. + Before you start, send a message to the [[http://hadoop.apache.org/hive/mailing_lists.html#Developers|Hive developer mailing list]], or file a bug report in [[https://issues.apache.org/jira/browse/HIVE|JIRA]]. Describe your proposed changes and check that they fit in with what others are doing and have planned for the project. Be patient, it may take folks a while to understand your requirements. Modify the source code and add some (very) nice features using your favorite IDE.<<BR>> @@ -165, +165 @@ }}} If you are an Eclipse user, you can apply a patch by : 1. Right click project name in Package Explorer , 2. Team -> Apply Patch - == Review Process (Proposal) == + == Review Process == If your patch contains more than 2 files that are changed and not yet had a review, please submit to [[http://reviews.apache.org |Review Board]]. Some helpful hints for Review Board: * When creating a review request you should select the "hive" repository and enter "http://svn.apache.org/repos/asf/hive/trunk"; in the "Base Directory" field. + * If you're using git instead of svn, you will need to select the {{{hive-git}}} repository. * Add the JIRA ID to the Bugs field, e.g. "HIVE-1212". - * Review Board needs this information in order to automatically post review comments back to the original JIRA ticket. * Add "hive" to the "Groups" field. * This ensures that Review Board will send a notification email to the hive-dev list. * Use JIRA name and the short title for the "Summary" Field (eg: HIVE-1234: fix X Y Z) * You will need to click on the Publish button after you make a change. + * Please add a comment to the JIRA ticket with a link to your review request. * Use the [[CodeReviewChecklist| code review checklist]] as a guide when doing reviews * Reviewers can approve the patch by clicking on the "Ship it" option. * Should your patch earn a -1 review, set the issue status to 'Resume Progress', upload a patch to Review Board with necessary fixes and then set the status to 'Submit Patch' again. @@ -182, +183 @@ ''NOTE:'' there was previously a rule about not uploading patches to JIRA until they had passed review board. We may adopt this eventually, but for now, keep uploading all patch versions to JIRA. == Contributing your work == - Finally, patches should be ''attached'' to an issue report in [[http://issues.apache.org/jira/browse/HIVE|Jira]] via the '''Attach File''' link on the issue's Jira. Please add a comment that asks for a code review following our [[CodeReviewChecklist|code review checklist]]. Please note that the attachment should be granted license to ASF for inclusion in ASF works (as per the [[http://www.apache.org/licenses/LICENSE-2.0|Apache License]] §5). + Finally, patches should be ''attached'' to an issue report in [[http://issues.apache.org/jira/browse/HIVE|JIRA]] via the '''Attach File''' link on the issue's JIRA. Please add a comment that asks for a code review following our [[CodeReviewChecklist|code review checklist]]. Please note that the attachment should be granted license to ASF for inclusion in ASF works (as per the [[http://www.apache.org/licenses/LICENSE-2.0|Apache License]] §5). - When you believe that your patch is ready to be committed, select the '''Submit Patch''' link on the issue's Jira. + When you believe that your patch is ready to be committed, select the '''Submit Patch''' link on the issue's JIRA. Folks should run {{{ant clean test}}} before selecting '''Submit Patch'''. Tests should all pass. If your patch involves performance optimizations, they should be validated by benchmarks that demonstrate an improvement. - If your patch creates an incompatibility with the latest major release, then you must set the '''Incompatible change''' flag on the issue's Jira 'and' fill in the '''Release Note''' field with an explanation of the impact of the incompatibility and the necessary steps users must take. + If your patch creates an incompatibility with the latest major release, then you must set the '''Incompatible change''' flag on the issue's JIRA 'and' fill in the '''Release Note''' field with an explanation of the impact of the incompatibility and the necessary steps users must take. - If your patch implements a major feature or improvement, then you must fill in the '''Release Note''' field on the issue's Jira with an explanation of the feature that will be comprehensible by the end user. + If your patch implements a major feature or improvement, then you must fill in the '''Release Note''' field on the issue's JIRA with an explanation of the feature that will be comprehensible by the end user. A committer should evaluate the patch within a few days and either: commit it; or reject it with an explanation. Please be patient. Committers are busy people too. If no one responds to your patch after a few days, please make friendly reminders. Please incorporate other's suggestions into your patch if you think they're reasonable. Finally, remember that even a patch that is not committed is useful to the community. - Should your patch receive a "-1" select the '''Resume Progress''' on the issue's Jira, upload a new patch with necessary fixes, and then select the '''Submit Patch''' link again. + Should your patch receive a "-1" select the '''Resume Progress''' on the issue's JIRA, upload a new patch with necessary fixes, and then select the '''Submit Patch''' link again. Committers: for non-trivial changes, it is best to get another committer to review your patches before commit. Use '''Submit Patch''' link like other contributors, and then wait for a "+1" from another committer before committing. Please also try to frequently review things in the patch queue. - == Jira Guidelines == + == JIRA Guidelines == - Please comment on issues in Jira, making their concerns known. Please also vote for issues that are a high priority for you. + Please comment on issues in JIRA, making their concerns known. Please also vote for issues that are a high priority for you. - Please refrain from editing descriptions and comments if possible, as edits spam the mailing list and clutter Jira's "All" display, which is otherwise very useful. Instead, preview descriptions and comments using the preview button (on the right) before posting them. Keep descriptions brief and save more elaborate proposals for comments, since descriptions are included in Jira's automatically sent messages. If you change your mind, note this in a new comment, rather than editing an older comment. The issue should preserve this history of the discussion. + Please refrain from editing descriptions and comments if possible, as edits spam the mailing list and clutter JIRA's "All" display, which is otherwise very useful. Instead, preview descriptions and comments using the preview button (on the right) before posting them. Keep descriptions brief and save more elaborate proposals for comments, since descriptions are included in JIRA's automatically sent messages. If you change your mind, note this in a new comment, rather than editing an older comment. The issue should preserve this history of the discussion. == Generating Code ==
